Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build against Fast DDS 3.0 #776

Merged
merged 13 commits into from
Jan 22, 2025
Merged

Conversation

MiguelCompany
Copy link
Collaborator

@MiguelCompany MiguelCompany commented Sep 6, 2024

This PR brings in the necessary changes to build against Fast DDS 3.0.x

It has been reviewed by the eProsima Team in eProsima#32

Part of ros2/ros2#1598

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiguelCompany DCO is missing, can you check that?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two minor questions.

Otherwise, this tentatively looks good to me, but I'd like to see full CI, including Windows Debug and a clang run.

rmw_fastrtps_cpp/CMakeLists.txt Show resolved Hide resolved
@bshantam97
Copy link

@MiguelCompany Hello, when will the FastDDS3 RMW Changes be merged with ROS2?

@MiguelCompany MiguelCompany force-pushed the fastdds-3.0 branch 2 times, most recently from a2dca7c to 8855c99 Compare December 4, 2024 08:51
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, but since we are removing fastrtps_cmake_module we should also update the QUALITY_DECLARATION.md files to remove any mention of it.

@MiguelCompany MiguelCompany force-pushed the fastdds-3.0 branch 2 times, most recently from 4fec43c to f628e6b Compare January 17, 2025 09:19
Mario-DL and others added 12 commits January 22, 2025 10:27
* Fast DDS 3.0: First commit

Signed-off-by: Ricardo González Moreno <[email protected]>

* Fast DDS 3.0: continue

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: update headers

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: move namespace from fastrtps to fastdds

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Update export macro to FASTDDS

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Revert header guard to the same name as the package name

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Update ReturnCode_t

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: remove deprecated test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Update representation in test

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Update is_plain() call

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: Update cmake extra dependencies to Fast 3.0.0 and doxygen predefied macro

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: TODO continue. Register type identifies if not registered

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: update headers

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: update to topicdatatype refactor

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: Update ReturnCode_t

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: move namespace from fastrtps to fastdds

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: typo in CMakeLists.txt

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: Typesupport receives rosidl_message_typesupport in construction

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: update headers

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: update to topicdatatype refactor

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: Update ReturnCode_t

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: move namespace from fastrtps to fastdds

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: update rme_dynamic_message methods to fastdds

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: use register_type_object_representation() method

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: subscirption: cast to DynamicType::_ref_type

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: required fastdds 3.0 in cmake extras

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: getter for ros msg typesupports

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: check return codes in write() operations

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: complete GetTypeIdentifiers() and solve minor warnings

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: required fastdds 3.0 in cmake extras

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: update typesupport

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: update headers and namespaces

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322. Fixes

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #21322: Apply rev suggestions

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_shared_cpp: linters

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_dynamic_cpp: linters

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21322: rmw_fastrtps_cpp: linters

Signed-off-by: Mario Dominguez <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Co-authored-by: Ricardo González Moreno <[email protected]>

Signed-off-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
@clalancette
Copy link
Contributor

CI for this is in ros2/ros2#1598 (comment)

@clalancette clalancette merged commit 915ef23 into ros2:rolling Jan 22, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants