Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade casts to support mapping ROS char into C signed char #99

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Downgrade casts to support mapping ROS char into C signed char #99

merged 1 commit into from
Apr 6, 2017

Conversation

gerkey
Copy link
Member

@gerkey gerkey commented Apr 6, 2017 •
edited
Loading

@gerkey gerkey self-assigned this Apr 6, 2017
@gerkey gerkey added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 6, 2017
@gerkey gerkey mentioned this pull request Apr 6, 2017
Merged
mikaelarguedas
mikaelarguedas approved these changes Apr 6, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when CI passed.
Could you rename the title of the PR to reflect that this is about downgrading casts and not "signed char mapping" before merging ? Thanks!

@gerkey gerkey changed the title Map ROS char into C signed char Downgrade casts to support mapping ROS char into C signed char Apr 6, 2017
@gerkey gerkey merged commit c8afdb3 into master Apr 6, 2017
@gerkey gerkey deleted the fix_test branch April 6, 2017 20:00
@gerkey gerkey removed the in review Waiting for review (Kanban column) label Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@gerkey gerkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerkey @mikaelarguedas