Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test2 #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test2 #2

wants to merge 2 commits into from

Conversation

rotemjordan
Copy link
Owner

No description provided.

@@ -1,4 +1,4 @@
resource "aws_s3_bucket" "data" {
resource "aws_s3_bucket" "data_" {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure S3 Bucket has public access blocks
    Resource: aws_s3_bucket.data_ | ID: BC_AWS_NETWORKING_52

How to Fix

resource "aws_s3_bucket" "bucket_good_1" {
  bucket = "bucket_good"
}

resource "aws_s3_bucket_public_access_block" "access_good_1" {
  bucket = aws_s3_bucket.bucket_good_1.id

  block_public_acls   = true
  block_public_policy = true
}

Description

When you create an S3 bucket, it is good practice to set the additional resource **aws_s3_bucket_public_access_block** to ensure the bucket is never accidentally public.

We recommend you ensure S3 bucket has public access blocks. If the public access block is not attached it defaults to False.

@@ -186,7 +186,7 @@
"vlq": "2.0.4",
"vrsource-tslint-rules": "6.0.0"
},
"// 4": "Overwrite graceful-fs to a version that does not rely on the 'natives' package. This fixes gulp for >= 10.13, more information: #28213",
"// 4": "Overwrite graceful-fs to a version that does not rely on the 'natives' package.This fixes gulp for >= 10.13, more information: #28213",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

materialize-css 1.0.0 / package.json

Total vulnerabilities: 4

Critical: 0High: 0Medium: 0Low: 4
Vulnerability ID Severity CVSSFixed in Status
CVE-2019-11002 LOW4-Open
CVE-2019-11003 LOW4-Open
CVE-2019-11004 LOW4-Open
CVE-2022-25349 LOW4-Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant