Skip to content

Commit

Permalink
msg/async: truly use first addr if multiple incoming addrs provided
Browse files Browse the repository at this point in the history
For incoming IPv4 and IPv6 dual stack support, there might be
multiple addresses provided in entity's addrvec.
The comment says we'll just pick whichever is listed first for now
to accept, whereas the implementation does quite the opposite.

Signed-off-by: xie xingguo <[email protected]>
  • Loading branch information
xiexingguo committed Dec 5, 2018
1 parent 948efa9 commit 50d8c8a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/msg/async/AsyncMessenger.cc
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,7 @@ AsyncConnectionRef AsyncMessenger::create_connect(
// FIXME: for ipv4 vs ipv6, check whether local host can handle ipv6 before
// trying it? for now, just pick whichever is listed first.
target = a;
break;
}

// create connection
Expand Down

0 comments on commit 50d8c8a

Please sign in to comment.