Skip to content

Commit

Permalink
Updating Appraisals and Lowering the Shoulda requirement, and only co…
Browse files Browse the repository at this point in the history
…nfiguring when spec helper when rails is newer...
  • Loading branch information
rposborne committed Nov 4, 2015
1 parent 298a917 commit cb1c3f4
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ cache: bundler
sudo: false

rvm:
- 2.1.4
- 2

matrix:
include:
Expand Down
6 changes: 3 additions & 3 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
appraise "rails3.2" do
gem "rails", "~> 3.2.17"
gem "rails", "~> 3.2.21"
end

appraise "rails4.0" do
gem "rails", "~> 4.0.4"
gem "rails", "~> 4.0.13"
end

appraise "rails4.1" do
gem "rails", "~> 4.1.0"
gem "rails", "~> 4.1.13"
end
3 changes: 2 additions & 1 deletion gemfiles/rails3.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "http://rubygems.org"

gem "rails", "~> 3.2.17"
gem "rails", "~> 3.2.21"
gem 'test-unit', '~> 3.0'

gemspec :path => "../"
4 changes: 2 additions & 2 deletions gemfiles/rails4.0.gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "http://rubygems.org"

gem "rails", "~> 4.0.4"
gem "rails", "~> 4.0.13"

gemspec :path => "../"
2 changes: 1 addition & 1 deletion gemfiles/rails4.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

source "http://rubygems.org"

gem "rails", "~> 4.1.0"
gem "rails", "~> 4.1.13"

gemspec :path => "../"
8 changes: 1 addition & 7 deletions mailboxer.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rspec-its', '~> 1.1'
s.add_development_dependency 'rspec-collection_matchers', '~> 1.1'
s.add_development_dependency('appraisal', '~> 1.0.0')
s.add_development_dependency('shoulda-matchers', '~> 3')
# Fixtures
#if RUBY_VERSION >= '1.9.2'
# s.add_development_dependency('factory_girl', '>= 3.0.0')
#else
#s.add_development_dependency('factory_girl', '~> 2.6.0')
#end
s.add_development_dependency('shoulda-matchers', '~> 2')
s.add_development_dependency('factory_girl', '~> 2.6.0')
# Population
s.add_development_dependency('forgery', '>= 0.3.6')
Expand Down
12 changes: 6 additions & 6 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@

# Shoulda Matchers
require 'shoulda/matchers'

Shoulda::Matchers.configure do |config|
config.integrate do |with|
# Choose a test framework:
with.test_framework :rspec
with.library :rails
if Shoulda::Matchers.respond_to?(:configure)
Shoulda::Matchers.configure do |config|
config.integrate do |with|
with.test_framework :rspec
with.library :rails
end
end
end

Expand Down

0 comments on commit cb1c3f4

Please sign in to comment.