Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #2398 from yahonda/diag_2394 #2402

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Merge pull request #2398 from yahonda/diag_2394 #2402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def supports_explain?
true
end

def explain(arel, binds = [])
def explain(arel, binds = [], options = [])
sql = "EXPLAIN PLAN FOR #{to_sql(arel, binds)}"
return if /FROM all_/.match?(sql)
if ORACLE_ENHANCED_CONNECTION == :jdbc
Expand All @@ -76,6 +76,11 @@ def explain(arel, binds = [])
select_values("SELECT * FROM TABLE(DBMS_XPLAN.DISPLAY)", "EXPLAIN").join("\n")
end

def build_explain_clause(options = [])
# Oracle does not have anything similar to "EXPLAIN ANALYZE"
# https://docs.oracle.com/en/database/oracle/oracle-database/23/sqlrf/EXPLAIN-PLAN.html#GUID-FD540872-4ED3-4936-96A2-362539931BA0
end

# New method in ActiveRecord 3.1
# Will add RETURNING clause in case of trigger generated primary keys
def sql_for_insert(sql, pk, binds, _returning)
Expand Down