Refactor SIMD ifdefs #797
Merged
Refactor SIMD ifdefs #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extconf check if SIMD is available, but then later on the `simd.h` header has extra logic to decide if it uses it or not. e.g. for SSE2 we have: ``` if defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__x86_64) || defined(_M_X64) || defined(_M_AMD64) ``` Which exclude i686 builds. Hence if we're not entering that `#if` we can end up with `JSON_ENABLE_SIMD=1` but neither `HAVE_SIMD_NEON` nor `HAVE_SIMD_SSE2`. So instead of relying on `JSON_ENABLE_SIMD` to check if any SIMD implementation is available, this commit introduce `HAVE_SIMD`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extconf check if SIMD is available, but then later on the
simd.hheader has extra logic to decide if it uses it or not.e.g. for SSE2 we have:
Which exclude i686 builds.
Hence if we're not entering that
#ifwe can end up withJSON_ENABLE_SIMD=1but neitherHAVE_SIMD_NEONnorHAVE_SIMD_SSE2.So instead of relying on
JSON_ENABLE_SIMDto check if any SIMD implementation is available, this commit introduceHAVE_SIMD.FYI: @hsbt @samyron