Implement RBS prepend support with comprehensive tests #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds full support for RBS::AST::Members::Prepend to properly handle prepended modules in type checking and method resolution. Key changes: - Add SigPrependNode class to handle prepend declarations - Separate prepended_modules from included_modules in ModuleEntity - Fix method resolution order: prepended modules → class → included modules - Update type compatibility checking to recognize prepended modules - Fix prepend module ordering (last prepended = first in ancestor chain) - Add break after finding first matching prepended method Testing: - Add test for basic prepend functionality - Add test for multiple prepended modules - Add test for prepend and include combination This ensures that when a class prepends a module, instances of that class are correctly recognized as compatible with the module type, and methods from prepended modules properly override class methods following Ruby semantics. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds full support for RBS::AST::Members::Prepend to properly handle prepended modules in type checking and method resolution.
Key changes:
Testing:
This ensures that when a class prepends a module, instances of that class are correctly recognized as compatible with the module type, and methods from prepended modules properly override class methods following Ruby semantics.
🤖 Generated with Claude Code