Skip to content

Commit

Permalink
thermal: more gimlet PID tuning
Browse files Browse the repository at this point in the history
With integral clamping working properly, previous PID terms
seem to create oscillations when tracking the set point under
load tests.  While these new PID terms don't completely resolve
that problem, they do seem to tame the variations to be less
annoying.
  • Loading branch information
mx-shift committed Nov 3, 2022
1 parent a04f404 commit b5e3b34
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions task/thermal/src/bsp/gimlet_bc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,10 @@ impl Bsp {

// Based on experimental tuning!
pid_config: PidConfig {
// If we're > 10 degrees from the target temperature, fans
// should be on at full power.
zero: 35.0,
gain_p: 6.75,
gain_i: 0.17,
gain_d: 4.5,
gain_p: 6.1,
gain_i: 0.09,
gain_d: 2.75,
},

inputs: &INPUTS,
Expand Down

0 comments on commit b5e3b34

Please sign in to comment.