Add license files to each of the subpackages #17856
Conversation
dosubot
bot
added
the
size:XS
|
Can all of these actually be published as MIT though? I would bet there are some packages with dependencies other than MIT |
|
@logan-markewich Good point, quite possibly not. However, if you search the repo tree for "license = "MIT" you'll find they are already being published to PyPI as MIT licensed via the package metadata in pyproject.toml (with the one GPL exception as noted above). |
|
After running a recursive scan using licensecheck, I do see some GPL and AGPL dependencies for various packages which would impact what license they could associate with them. Because GPL and AGPL are copyleft and the affected code is dynamically linked (like importing), those packages should also be GPL or AGPL.
|
|
Note: I opened a related issue on project |
|
Also opened a bug on nougat-ocr which also was improperly licensed. |
|
Opened anther issue on airbyte-python-cdk which didn't have a proper license. |
ericwb
force-pushed
the
include_license
branch
from
c79f0fa to
208c513
Compare
|
Ok, I have re-licensed the affected subpackages as a result of either direct or transitive dependencies on strong copyleft licenses (GPL and AGPL). |
This change adds the MIT license file to each of the subpackages so that poetry picks them up and includes them in the source distribution when published to PyPI. The one subpackage without any change is llama-index-integrations/readers/llama-index-readers-pdf-marker which already includes a GPL license file. Fixes: run-llama#10806 Signed-off-by: Eric Brown <[email protected]>
ericwb
force-pushed
the
include_license
branch
from
208c513 to
c465cb4
Compare
Description
This change adds the MIT license file to each of the subpackages so that poetry picks them up and includes them in the source distribution when published to PyPI.
The one subpackage not requiring any change is
llama-index-integrations/readers/llama-index-readers-pdf-markerwhich already includes a GPL license file.Fixes # 10806
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lintto appease the lint gods