Remove READ_EXTERNAL_STORAGE, add todos

ruskakimov · Jun 16, 2021 · 978391d · 978391d
1 parent 508d29d
commit 978391d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
@@ -5,8 +5,9 @@
          In most cases you can leave this as-is, but you if you want to provide
          additional functionality it is fine to subclass or reimplement
          FlutterApplication and put your custom class here. -->
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
+
+    <!--gallery_saver-->
+    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> 
 
     <application
         android:name="io.flutter.app.FlutterApplication"

diff --git a/lib/editing/ui/actionbar/editing_actionbar.dart b/lib/editing/ui/actionbar/editing_actionbar.dart
@@ -44,6 +44,7 @@ class EditingActionbar extends StatelessWidget {
   }
 
   Future<void> _openExportDialog(BuildContext context) async {
+    // TODO: Handle permanently denied storage permission
     if (await Permission.storage.request().isGranted) {
       final tempDir = await getTemporaryDirectory();
       final project = context.read<Project>();

diff --git a/lib/editing/ui/timeline/actionbar/import_audio_button.dart b/lib/editing/ui/timeline/actionbar/import_audio_button.dart
@@ -39,6 +39,7 @@ class ImportAudioButton extends StatelessWidget {
           onTap: playing
               ? null
               : () async {
+                  // TODO: Handle permanently denied storage permission
                   try {
                     final project = context.read<Project>();
                     await importer.importAudioTo(project);