Implement CRC-32 elements & verification #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found what made the tests from #106 fail: CRC elements aren't handled in the EBML header.
Changes:
parse_binary_exact
to get an exact amount of bytes in an arrayfn crc
) and to verify the data with the checksum (fn checksum
)(2.5) Add the
crc
crate to calculate the checksum(s) as per the specification.ebml_header
andsub_element
The complete error handling for CRC-32 is a bit more involved than just returning an error, but I'd say it's good enough for now.