Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deploy actions #335

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Improve deploy actions #335

merged 4 commits into from
Mar 16, 2023

Conversation

Luni-4
Copy link
Contributor

@Luni-4 Luni-4 commented Feb 10, 2023

This PR improves deploy actions simplifying some operations and removing some useless ones

@Luni-4 Luni-4 changed the title Remove deprecated operations from deploy Improve deploy actions Feb 14, 2023
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Luni-4
Copy link
Contributor Author

Luni-4 commented Feb 15, 2023

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

@fitzgen
Copy link
Member

fitzgen commented Feb 15, 2023

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

That is due to compiling the fuzz target with musl in that project; it shouldn't matter whether cargo fuzz itself is musl or not since the cargo fuzz binary does not include libFuzzer.

@fitzgen
Copy link
Member

fitzgen commented Feb 15, 2023

That is, we should not change away from musl for these deploy actions.

@Luni-4
Copy link
Contributor Author

Luni-4 commented Feb 16, 2023

It seems we have to change the musl target into the gnu one due to this error: https://github.com/sifis-home/sifis-generate/actions/runs/4183591092/jobs/7248563008#step:6:86

That is due to compiling the fuzz target with musl in that project; it shouldn't matter whether cargo fuzz itself is musl or not since the cargo fuzz binary does not include libFuzzer.

I haven't installed any musl library in that project, just cargo-fuzz which has been built with musl. I suppose this problem could happen to many others. Is there a workaround for that? Or can I add a gnu target to the deploy script?

I've tried to install musl libraries and launch this command cargo fuzz build --target x86_64-unknown-linux-musl but without any success

@Luni-4
Copy link
Contributor Author

Luni-4 commented Feb 16, 2023

@fitzgen I've decided to release a gnu binary too. What do you think?

@Luni-4
Copy link
Contributor Author

Luni-4 commented Feb 20, 2023

I was able to fix my problem setting up the target

cargo fuzz build --target x86_64-unknown-linux-gnu

@Luni-4
Copy link
Contributor Author

Luni-4 commented Mar 14, 2023

@fitzgen I rebased the PR, can we merge it now?

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen merged commit 9f886ff into rust-fuzz:main Mar 16, 2023
@Luni-4 Luni-4 deleted the improve-deploy branch March 16, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants