Remove note on accepted invalid should_panic syntax
#1955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had left a note about the fact that we accepted syntax for the `should_panic` attribute that was invalid. We no longer do, so let's remove that note.
rustbot
added
the
S-waiting-on-review
traviscross
added
the
S-waiting-on-stabilization
rustbot
removed
the
S-waiting-on-review
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 11, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
fmease
added a commit
to fmease/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 12, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Aug 12, 2025
Rollup merge of #145263 - rustbot:docs-update, r=ehuss Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Aug 13, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 18, 2025
Update books ## rust-lang/reference 6 commits in 1be151c051a082b542548c62cafbcb055fa8944f..59b8af811886313577615c2cf0e045f01faed88b 2025-08-10 18:21:53 UTC to 2025-08-08 01:00:04 UTC - Add LoongArch32 to inline-assembly documentation (rust-lang/reference#1942) - Update `no_builtins` to use the attribute template (rust-lang/reference#1909) - Update `global_allocator` to use the attribute template (rust-lang/reference#1919) - Update `windows_subsystem` to use the attribute template (rust-lang/reference#1920) - Remove note on accepted invalid `should_panic` syntax (rust-lang/reference#1955) - specify relative drop order of pattern bindings (rust-lang/reference#1953) ## rust-lang/rust-by-example 1 commits in bd1279cdc9865bfff605e741fb76a0b2f07314a7..adc1f3b9012ad3255eea2054ca30596a953d053d 2025-08-08 12:02:24 UTC to 2025-08-08 12:02:24 UTC - Update Chinese translations in `zh.po` (rust-lang/rust-by-example#1950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had left a note about the fact that we accepted syntax for the
should_panicattribute that was invalid. We no longer do, so let's remove that note.See:
#[should_panic]to the new attribute parsing infrastructure rust#143808cc @ehuss @Zalathar