RISC-V Extensions update including 28 extensions to stabilize #1987
+85
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
a4lg
force-pushed
the
riscv-extensions-2025.1
branch
from
1ef6f06 to
c60bc59
Compare
The `Zb` extension does not exist and we instead have the `B` extension which is a superset of the three subextensions: `Zba`, `Zbb` and `Zbs`. This commit fixes this issue and updates the reference URL to the source code of the latest ratified ISA Manual (version 20250508). To align with rust-lang/rust#145948, this commit performs rename, not removal.
This is the latest ratified ISA Manual version and more importantly, some individual documents are merged into this. So, this commit consistently use this Manual (this version) where possible. Along with this, this commit substitutes link IDs from `rv-zb-*` to `rv-*` because `rv-zb-*` will look like the different document (bit-manipulation) is referenced.
rust-lang/rust#140139 changed the target feature implication without updating the Reference. This commit fixes this issue.
a4lg
force-pushed
the
riscv-extensions-2025.1
branch
from
c60bc59 to
25d43f0
Compare
Because unstable "B" (incorrectly named as `zb`) was there, this commit
adds 28 minus one ("B") new extensions to be stabilized.
This commit directly corresponds to rust-lang/rust#145948.
References:
1. RISC-V Instruction Set Manual (version 20250508):
<https://github.com/riscv/riscv-isa-manual/tree/20250508>
2. RISC-V Profiles (version 1.0 - RVA23 is not stabilized at the time):
<https://github.com/riscv/riscv-profiles/tree/v1.0>
3. RISC-V Profiles (RVA23/RVB23-ratified version):
<https://github.com/riscv/riscv-profiles/tree/rva23-rvb23-ratified>
a4lg
force-pushed
the
riscv-extensions-2025.1
branch
from
25d43f0 to
a35f1c8
Compare
Possible ConsiderationSome platform behavior extensions are hard to make a short, concise summary. Do we prefer to keep long(er than usual) descriptions? Or, do we just link to the RISC-V Profiles documentation and let it explain? My Current PositionI prefer the latter if allowed but mdbook design is confirmed not broken so the current approach (long descriptions) is okay for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR directly corresponds to rust-lang/rust#145948 but commit 2 through 4 fixes some minor issues outside the scope of that PR (still in this PR because we have to make the reference consistent).