Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Simplify dummy proc-macro-srv #18672

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 12, 2024

It feels a bit silly to require this at this point

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2024
@lnicola
Copy link
Member

lnicola commented Dec 13, 2024

The variable was added because of concerns about the server not being as "stable" as the stable toolchain. Should we get this approved by the compiler or another team?

@Veykril
Copy link
Member Author

Veykril commented Dec 13, 2024

Hmm, right. I'll repurpose this for the other cleanup then only

@Veykril Veykril enabled auto-merge December 13, 2024 08:30
@Veykril Veykril added this pull request to the merge queue Dec 13, 2024
Merged via the queue into rust-lang:master with commit 7ce807b Dec 13, 2024
9 checks passed
@Veykril Veykril deleted the push-lurnqpqtzvzq branch December 13, 2024 08:58
@Veykril
Copy link
Member Author

Veykril commented Dec 13, 2024

i forgot to change the commit message whoops

@Veykril Veykril changed the title internal: Do not require a special env var to be set for the proc-macro-srv internal: Simplify dummy proc-macro-srv Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants