Implement parameter variance inference #18774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-ysppqxpuknnw
branch
from
dd3297b to
f267d86
Compare
Veykril
force-pushed
the
push-ysppqxpuknnw
branch
from
f267d86 to
3fc5391
Compare
Veykril
force-pushed
the
push-ysppqxpuknnw
branch
2 times, most recently
from
e02f3be to
13a5ac4
Compare
Veykril
force-pushed
the
push-ysppqxpuknnw
branch
from
13a5ac4 to
60e28c6
Compare
Veykril
force-pushed
the
push-ysppqxpuknnw
branch
from
b284865 to
2d299ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lacks any support for impl trait in type aliases (assoc or free) and functions are not fully supported as we lack lifetime elision. RPITs should also be supported here, but we don't count them as
GenericDefIdyet so.The inference does not work perfectly unfortunately as it may run into query cycles which we would need to resolve via fixpoint iteration which current salsa does not support (see module doc). Likewise, Const expressions can affect whether a parameter turns invariant which we also lack sometimes.