Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consider Enum::Variant even when it comes from a different crate #18779

Merged
merged 1 commit into from
Dec 29, 2024
Merged

fix: Consider Enum::Variant even when it comes from a different crate #18779

merged 1 commit into from
Dec 29, 2024

Conversation

ChayimFriedman2
Copy link
Contributor

Fixes #18768.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2024
Veykril
Veykril approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating so quickly (so it didnt make it onto the stable release), and sorry for introducing it (in hindsight it should've been obvious that that wouldn't work)

@Veykril Veykril added this pull request to the merge queue Dec 29, 2024
Merged via the queue into rust-lang:master with commit 02d1bf3 Dec 29, 2024
9 checks passed
@ChayimFriedman2 ChayimFriedman2 deleted the enum-variant branch December 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-needs-backporting S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generic arguments are not allowed on modules on #[derive(Deserialize)]
3 participants
@ChayimFriedman2 @Veykril @rustbot