internal: Create a quoting mechanism instead of textual AST make #18790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here possible This will help for the quote macro for `ast::make`.
This will also help for the make's quote macro.
Instead of messing with textual `make`. And port one `make` helper to it, for the sake of testing.
And implement addons as necessary. There are many more makers to be moved, and I'm not completely satisfied with this (due to the ease of making a mistake in the AST structure, and slightly less but also because of the need to remember whitespaces), but this is already enough to see how this will look like.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Dec 30, 2024
Same here, clearly not the final solution but its good enough to work around our issues for now (and not that invasive so easily replaceable in the future) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And port a few makers.
Fixes #18780, but I suspect there are many more like it lurking, and the work won't finish until we port them all.
I'm not completely satisfied with this (due to the ease of making a mistake in the AST structure, and slightly less but also because of the need to remember whitespaces), but this is already enough to see how this will look like. So I sent a PR to see how people will respond.
Can be reviewed commit by commit.