fix: Track diagnostic generations per package #20459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Oh, right. In current implementation, the diagnostics from the previous runs would outlive into the next generation altogether workspacewise if there's any diagnostics reported in that workspace. I had considered this (actually, inscribing diagnostics into both workspaces and packages) for the different purpose, for granulated erasure of outdated diagnostics for scenarios like check on save is turned off and flychecks are triggered sporadically on packages but it didn't worked well and I just oversimplified things with disappointment. But as you said, this makes solid improvements in normal usage scenarios 👍
rustbot
removed
the
S-waiting-on-review
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that once flycheck is done, we will clear all diagnostics from the previous run. Why is this nice? Well, right now if you have flycheck diagnostics in crate b, then edit crate a (where crate b depends on crate a) we will get diagnostics in crate a while b's old diagnostics stick around. With this change b will get cleared properly, reducing the amount of diagnostics shown in the problems pane of editors.
r? @ShoyuVanilla