-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Insights: rust-lang/rust-clippy
Overview
Could not load contribution data
Please try again later
90 Pull requests merged by 31 people
-
clean-up
collapsible_if
a bit#15503 merged
Aug 17, 2025 -
Misc
clippy_dev
changes#14896 merged
Aug 17, 2025 -
similar_names
stop linting for 3-char names#15100 merged
Aug 16, 2025 -
clean-up
unnecessary_unwrap
a bit#15489 merged
Aug 16, 2025 -
{borrow,ptr}_as_ptr
: don't lint inside proc-macros#15473 merged
Aug 15, 2025 -
unnecessary_operation
: add space between stmts in suggestion#15432 merged
Aug 14, 2025 -
Fix
match_ref_pats
FP on match scrutinee of never type#15474 merged
Aug 14, 2025 -
result_large_err
: getDefId
fromAdtDef
instead ofexpect
ing#15467 merged
Aug 14, 2025 -
Adjust
declare_interior_mutable_const
lint's category#15454 merged
Aug 14, 2025 -
Bump slab from 0.4.10 to 0.4.11 in /clippy_test_deps
#15471 merged
Aug 13, 2025 -
as_ptr_cast
: move the unfixable case into a separate file#15475 merged
Aug 13, 2025 -
move
char_lit_as_u8
under the explicit-cast case#15477 merged
Aug 13, 2025 -
fix
unnecessary_semicolon
: don't lint on stmts with attrs#15466 merged
Aug 12, 2025 -
Update actions/checkouts to v5
#15457 merged
Aug 11, 2025 -
Get myself off assignment rotation
#15459 merged
Aug 11, 2025 -
Correct
needless_borrow_for_generic_args
doc comment#15440 merged
Aug 11, 2025 -
doc: use
is_some_and
instead ofmap_or(false, _)
#15455 merged
Aug 11, 2025 -
Update CONTRIBUTING.md to use RustRover instead of IntelliJ Rust
#15448 merged
Aug 10, 2025 -
feat: introduce
path_to_local_with_projections
#15396 merged
Aug 10, 2025 -
fix &str type check in
from_str_radix_10
#15410 merged
Aug 9, 2025 -
expect_fun_call
: move helper functions out of the main one#15446 merged
Aug 9, 2025 -
Add "PowerPC" to the list of valid CamelCase strings in docs
#15447 merged
Aug 9, 2025 -
[[infinite_loop] fix infinite loop false positive
#15157 merged
Aug 9, 2025 -
Do not attempt to compute size of a type with escaping lifetimes
#15434 merged
Aug 9, 2025 -
use a let-chain in
needless_bool
#15444 merged
Aug 8, 2025 -
move
crosspointer_transmute
fromcomplexity
tosuspicious
#15403 merged
Aug 8, 2025 -
eta_reduction
: don't refer to ADT constructors as "function"s#15436 merged
Aug 8, 2025 -
Reuse previous
Vec
allocation in loop#15428 merged
Aug 7, 2025 -
Rustup
#15431 merged
Aug 7, 2025 -
Fix typo in lint issue template
#15427 merged
Aug 7, 2025 -
Optimize
needless_bool
lint#15423 merged
Aug 6, 2025 -
Optimize
incompatible_msrv
lint#15422 merged
Aug 6, 2025 -
Remove CSS bootstrap dependency
#15251 merged
Aug 6, 2025 -
Fix suggestion for
collapsible_if
andcollapsible_else_if
when the innerif
is enclosed in parentheses#15304 merged
Aug 6, 2025 -
expand the issue template for new lints
#15336 merged
Aug 6, 2025 -
Do not lint for
wildcard_imports
in external macro#15413 merged
Aug 5, 2025 -
Fix
unnecessary_sort_by
lint method consistency in message and suggestion#15416 merged
Aug 5, 2025 -
Move
cognitive_complexity
lint fromnursery
torestriction
#15415 merged
Aug 5, 2025 -
Generate lint count in template
#15414 merged
Aug 5, 2025 -
Split
possible_missing_else
fromsuspicious_else_formatting
#15317 merged
Aug 4, 2025 -
Issues priority
#15393 merged
Aug 4, 2025 -
Remove rogue comma from infallible_try_from lint message
#15409 merged
Aug 4, 2025 -
Fix not showing deprecated lints
#15407 merged
Aug 4, 2025 -
Changelog for Clippy 1.89 🌽
#15375 merged
Aug 4, 2025 -
clean-up
semicolon_inside_block
#15390 merged
Aug 4, 2025 -
don't allocate a
Vec
in anIterator::chain
#15400 merged
Aug 3, 2025 -
clean-up
SourceFileRange::as_str
#15401 merged
Aug 3, 2025 -
fix option-if-let-else lint
#15394 merged
Aug 3, 2025 -
Simplify boolean expression in
manual_assert
#15368 merged
Aug 3, 2025 -
Extend
implicit_clone
to handleto_string
calls#14177 merged
Aug 2, 2025 -
{flat_,}map_identity
: recognize (tuple) struct de- and restructuring#15261 merged
Aug 2, 2025 -
fix:
let_with_type_underscore
don't eat closing paren inlet (i): _ = 0;
#15386 merged
Aug 2, 2025 -
Optimize broken_links by 99.77%
#15385 merged
Aug 2, 2025 -
Do not specialize for
if_chain
any longer#15362 merged
Aug 1, 2025 -
Output lintcheck summary HTML markdown in order
#15371 merged
Jul 31, 2025 -
Optimize some usages of
!!
and--
in suggestions#15366 merged
Jul 30, 2025 -
Fix
iter_on_single_items
FP on function pointers and let stmts#15013 merged
Jul 30, 2025 -
chore: fix some minor issues in comments
#15372 merged
Jul 30, 2025 -
Fix
min_ident_chars
: ignore on trait impl.#15275 merged
Jul 30, 2025 -
Do not autofix comments containing bare CR
#15175 merged
Jul 29, 2025 -
Fix
search_is_some
suggests wrongly inside macro#15135 merged
Jul 29, 2025 -
Fix typo in internal error message
#15363 merged
Jul 28, 2025 -
Do not treat NixOS as a Pascal-cased identifier
#15361 merged
Jul 28, 2025 -
Fix
cast-lossless
should not suggest when casting type is from macro input#15358 merged
Jul 28, 2025 -
Fix
match_single_binding
wrongly handles scope#15060 merged
Jul 28, 2025 -
Fix typo non_std_lazy_statics.rs
#15357 merged
Jul 27, 2025 -
Fix
let_unit_value
suggests wrongly for format macros#15085 merged
Jul 27, 2025 -
fix:
unnecessary_map_or
don't add parens if the parent expr comes f…#15345 merged
Jul 27, 2025 -
Fix
empty_structs_with_brackets
suggests wrongly on generics#15355 merged
Jul 27, 2025 -
Detect prefixed attributes as duplicated
#15212 merged
Jul 26, 2025 -
fix ip_constant when call wrapped in extra parens
#15339 merged
Jul 26, 2025 -
Get myself back on assignment rotation
#15346 merged
Jul 25, 2025 -
Rustup
#15341 merged
Jul 25, 2025 -
Remove "Known problems" section for
clippy::redundant_closure
#15331 merged
Jul 25, 2025 -
Fix
if_then_some_else_none
FP when require type coercion#15267 merged
Jul 24, 2025 -
Correct help message for
arc_with_non_send_sync
#15332 merged
Jul 24, 2025 -
Fix
module_name_repetitions
FP on exported macros#15319 merged
Jul 23, 2025 -
Fix
unused_async
FP on function withtodo!
#15308 merged
Jul 23, 2025 -
Fix false positive in useless_attribute with redundant_imports
#15318 merged
Jul 21, 2025 -
fix: ignore pattern_type_mismatch when external macro owns the match
#15306 merged
Jul 20, 2025 -
Fixed issue #15192
#15241 merged
Jul 20, 2025 -
Fix capacity overflow in
single_match
with deref patterns#15124 merged
Jul 20, 2025 -
Fix
never_loop
forget to removebreak
in suggestion#15064 merged
Jul 20, 2025 -
Fix
missing_inline_in_public_items
FP on functions withextern
#15313 merged
Jul 19, 2025 -
Fix
filter_map_bool_then
wrongly suggests macro definitions#15048 merged
Jul 19, 2025 -
Fix
needless_range_loop
FP on array literals#15314 merged
Jul 19, 2025 -
Simplify
must_use_candidate
spans#15310 merged
Jul 19, 2025 -
Remove unused option
None
forLEVEL_FILTERS_DEFAULT
#15315 merged
Jul 19, 2025 -
Fix
empty_with_brackets
span handling#15311 merged
Jul 19, 2025 -
Warn about
const
instability wrt MSRV#15297 merged
Jul 18, 2025
48 Pull requests opened by 15 people
-
Fix `missing_inline_in_public_items` fail to fulfill `expect` in `--test` build
#15320 opened
Jul 21, 2025 -
`needless_return`: do not lint on proc macros
#15329 opened
Jul 23, 2025 -
PoC: Integer range analysis
#15342 opened
Jul 25, 2025 -
fix: `unnested_or_patterns` FP on structs with only shorthand field pats
#15343 opened
Jul 25, 2025 -
clean-up `unnested_or_patterns`
#15344 opened
Jul 25, 2025 -
Do not replace `match` by `if` if any arm contains a binding
#15352 opened
Jul 26, 2025 -
Fix`unnecessary_safety_comment` does not lint for the first line
#15354 opened
Jul 27, 2025 -
Fix `never_loop` forget to remove `break` in nested loop
#15356 opened
Jul 27, 2025 -
Fix cast_sign_loss false positive for float to uint casts
#15382 opened
Jul 31, 2025 -
Add suggestion to `cast_sign_loss` and `cast_possible_wrap` using the `cast_{un,}signed()` methods
#15384 opened
Aug 1, 2025 -
Check config options in test suite
#15397 opened
Aug 2, 2025 -
feat: `manual_rotate` also recognize non-consts
#15402 opened
Aug 3, 2025 -
overhaul `mut_mut`
#15417 opened
Aug 5, 2025 -
`as_pointer_underscore`: don't lint when casting fn item pointers
#15418 opened
Aug 5, 2025 -
WIP: `mut_mut`: generalize the from-expansion check
#15419 opened
Aug 5, 2025 -
add structured suggestions to `double_parens`
#15420 opened
Aug 5, 2025 -
fix: `semicolon_inside_block` don't fire if block is surrounded by parens
#15421 opened
Aug 5, 2025 -
`cast_slice_from_raw_parts`: check for implicit cast to raw slice pointer
#15437 opened
Aug 7, 2025 -
`unnecessary_mut_passed`: add structured suggestion
#15438 opened
Aug 8, 2025 -
change `suspicious_operation_groupings` to work on the HIR instead of the AST
#15443 opened
Aug 8, 2025 -
Rewrite `unwrap_in_result` lint
#15445 opened
Aug 8, 2025 -
`is_expr_identity_of_pat`: simplify using `(unordered_)over`
#15450 opened
Aug 10, 2025 -
Add `needless_conversion_for_trait` lint
#15451 opened
Aug 10, 2025 -
fix(disallowed_macros): Fix emitting on attr macros
#15452 opened
Aug 10, 2025 -
`let_unit_with_type_underscore`: make early-pass
#15458 opened
Aug 11, 2025 -
`unnecessary_operation`: don't suggest autofixes on composite types with fields of uncertain types
#15460 opened
Aug 11, 2025 -
`too_many_lines`: only highlight the function signature
#15461 opened
Aug 11, 2025 -
simplify `too_many_args`
#15462 opened
Aug 11, 2025 -
fix `self_named_module_files`: track module with relative path
#15469 opened
Aug 12, 2025 -
Fix `semicolon_inside_block` FP when attribute over expr is not enabled
#15476 opened
Aug 13, 2025 -
clean-up `ptr_cast_constness`
#15478 opened
Aug 13, 2025 -
split `cast_ptr_alignment`
#15479 opened
Aug 13, 2025 -
`ptr_as_ptr`: move to `if`
#15480 opened
Aug 13, 2025 -
fix `unnecessary_semicolon`: FN on `#[feature(stmt_expr_attributes)]`
#15481 opened
Aug 13, 2025 -
fix `equatable_if_let`: don't suggest `=` in const context
#15482 opened
Aug 13, 2025 -
fix `or_then_unwrap`: suggestion preserves macro calls
#15483 opened
Aug 13, 2025 -
Fix FP of `needless_range_loop` when meeting multidimensional array
#15486 opened
Aug 14, 2025 -
cast_possible_truncation: Support `size_of`, `align_of`, and `size_of_val`
#15488 opened
Aug 14, 2025 -
`msrv`: replace nested `if`s with guard clauses
#15490 opened
Aug 14, 2025 -
fix `manual_is_ascii_check`: also add explicit type when linting `matches!`
#15492 opened
Aug 15, 2025 -
Add the `iter_last_slice` lint
#15496 opened
Aug 15, 2025 -
`bool_comparison`: no longer lint on `!x != y`
#15498 opened
Aug 15, 2025 -
extract `bool_comparison` to a separate file
#15499 opened
Aug 15, 2025 -
missing_safety_doc: guide them out of an HTML block with a header
#15500 opened
Aug 16, 2025 -
`missing_inline_in_public_items`: fix lint emission source HirId
#15501 opened
Aug 16, 2025 -
Refactor run and mtime functions: safer error handling, cleaner struc…
#15505 opened
Aug 17, 2025 -
`ptr_arg`: clean-up a bit
#15507 opened
Aug 17, 2025 -
extract `duplicate_underscore_argument`, and move it into `functions`
#15508 opened
Aug 17, 2025
65 Issues closed by 19 people
-
Stop triggering `similar_names` for 3-character names
#14869 closed
Aug 16, 2025 -
False positive `missing_const_for_fn` if there are `#[start]` and `#[test]` both are present
#13946 closed
Aug 16, 2025 -
`borrow_as_ptr` and `ptr_as_ptr` false positives in `windows::core::implement` macro invocation
#15398 closed
Aug 15, 2025 -
ICE in zero_sized_map_values
#14972 closed
Aug 14, 2025 -
`match_ref_pats` matching on macros like `unimplemented` there is nothing that can be dereferenced
#15378 closed
Aug 14, 2025 -
manual_div_ceil lint suggests broken code
#15485 closed
Aug 14, 2025 -
clippy::swap_with_temporary false positive
#15472 closed
Aug 13, 2025 -
`unnecessary_semicolon` FP on expression statements with attributes
#15426 closed
Aug 12, 2025 -
Update CONTRIBUTING.md to include RustRover instead of deprecated IntelliJ Rust
#15406 closed
Aug 10, 2025 -
`unwrap_used` specialization for writing to `String` broken in 1.89
#15449 closed
Aug 10, 2025 -
Latest Clippy tags `unused_imports` on trait imports spuriously
#15442 closed
Aug 9, 2025 -
[meta] Reccommend checking code with all clippy lints before filing a new issue
#13424 closed
Aug 9, 2025 -
False positive for `infinite_loop` inside `async` block in function
#14000 closed
Aug 9, 2025 -
Internal compiler error after upgrading to 1.89.0
#15429 closed
Aug 9, 2025 -
unused or incorrect lints in Cargo.toml fail silently
#12124 closed
Aug 9, 2025 -
Lint: useless/unidiomatic match statement on bool
#8014 closed
Aug 9, 2025 -
redundant_closure calls a tuple struct enum variant a function
#8817 closed
Aug 8, 2025 -
incorrect fix for `collapsable_if` and `collapsable_else_if` when inner `if` is wrapped in parens
#15303 closed
Aug 6, 2025 -
Possible suggestion improvements on match_ref_pats
#849 closed
Aug 6, 2025 -
`wildcard_imports` (with `warn-on-all-wildcard-imports`) warns about wildcards within external macros
#15412 closed
Aug 5, 2025 -
Failed to build Clippy from source
#15411 closed
Aug 5, 2025 -
`clippy::let_and_return` suggestion causes error because value does not live long enough
#13735 closed
Aug 4, 2025 -
Detect workspaces using different editions among different crates
#15383 closed
Aug 4, 2025 -
`excessive_precision` triggered when adding the `+` in scientific notation
#15408 closed
Aug 4, 2025 -
`cargo clippy` does not process build scripts
#2802 closed
Aug 4, 2025 -
cargo clippy --all misses crates that are not part of the workspace
#2238 closed
Aug 4, 2025 -
Add lint for impl-only-use RFC
#2476 closed
Aug 3, 2025 -
Warn on source/test depending on files not being packaged
#1950 closed
Aug 3, 2025 -
lint implementing a trait for a trait object
#731 closed
Aug 3, 2025 -
Suggest using cfg_if crate for chains of cfg(A) and cfg(not(A))
#1894 closed
Aug 3, 2025 -
Warn on method names overlapping common traits
#2231 closed
Aug 3, 2025 -
nonminimal_bool lint for meta items
#1893 closed
Aug 3, 2025 -
Double backticks in assist of `doc_markdown`
#14092 closed
Aug 3, 2025 -
`option-if-let-else`: no method named `map_or` found for raw pointer `*const std::option::Option<i32>`
#15379 closed
Aug 3, 2025 -
option-if-let-else botches map_or_else fn call
#15002 closed
Aug 3, 2025 -
`manual_assert` does not simplify expressions
#15359 closed
Aug 3, 2025 -
Bug when applying a fix for `clippy::if-then-some-else-none`
#15395 closed
Aug 2, 2025 -
`let-with-type-underscore` is removing `)` causing syntax error
#15377 closed
Aug 2, 2025 -
Lintcheck outputs fields in wrong order
#15370 closed
Jul 31, 2025 -
`iter-on-single-items` breaks code in macro context that takes IntoIterator
#14981 closed
Jul 30, 2025 -
`min_ident_chars` triggers on implementation block for foreign traits
#13396 closed
Jul 30, 2025 -
`four_forward_slashes` does not know that doc comments cannot contain "bare CR"
#15174 closed
Jul 29, 2025 -
`search_is_some` suggests broken code when match guard is present
#15102 closed
Jul 29, 2025 -
[clippy::doc_markdown] Default whitelist: Add 'NixOS'
#15360 closed
Jul 28, 2025 -
`cast-lossless` breaks macro
#15348 closed
Jul 28, 2025 -
match_single_binding suggests code with invalid syntax
#15269 closed
Jul 28, 2025 -
`match_single_binding`: missing brackets
#15018 closed
Jul 28, 2025 -
The suggestion of let_unit_value is invalid when the value is used in formatted in print
#15061 closed
Jul 27, 2025 -
suggestions for `unnecessary_map_or` suggest unnecessary parentheses
#14714 closed
Jul 27, 2025 -
`empty-structs-with-brackets` wants to remove const parameters of structs 🤔
#15349 closed
Jul 27, 2025 -
Prefixed attributes are not detected as duplicated
#14942 closed
Jul 26, 2025 -
Invalid core::time:::Instant --fix
#15330 closed
Jul 26, 2025 -
cargo clippy --fix mishandles order of operations [neg_multiply]
#15340 closed
Jul 25, 2025 -
`if-then-some-else-none` changes return type
#15257 closed
Jul 24, 2025 -
`module_name_repetitions` on exported macros should use crate name, not module name
#14095 closed
Jul 23, 2025 -
unused_async triggers on stubs with todo!()
#15305 closed
Jul 23, 2025 -
[Pattern_type_mismatch] clippy encouraging to dereference, but not needed.
#12325 closed
Jul 22, 2025 -
too_many_lines not triggered on functions with #[tracing::instrument]
#13753 closed
Jul 22, 2025 -
False Positive `useless_attribute` with `#[expect(redundant_imports)]`
#15316 closed
Jul 21, 2025 -
large_enum_variant propose a wrong solution for no_std
#15192 closed
Jul 20, 2025 -
ICE: capacity overflow
#14882 closed
Jul 20, 2025 -
`never_loop` should also remove `break` labels that were inside the loop
#15007 closed
Jul 20, 2025 -
missing_inline_in_public_items: false positive on externally exported function
#15301 closed
Jul 19, 2025 -
`filter_map_bool_then` should not show the macro definition in suggestions
#15047 closed
Jul 19, 2025 -
needless_range_loop doesn't recognize anonymous arrays
#15309 closed
Jul 19, 2025
52 Issues opened by 37 people
-
`ptr_arg` doesn't work with `impl AsRef<Path>`
#15506 opened
Aug 17, 2025 -
`ptr_arg` should trigger for `Option<&PathBuf>`
#15504 opened
Aug 17, 2025 -
`collapsible_if` ignore gated out lines between two if
#15502 opened
Aug 16, 2025 -
`bool_comparison` mangles macro invocations
#15497 opened
Aug 15, 2025 -
`self_named_module_files`: Enforce consistent naming for leaf modules
#15495 opened
Aug 15, 2025 -
`let_unit_value` suggestion replacing variable in println with unit
#15494 opened
Aug 15, 2025 -
Correct manual impl Default
#15493 opened
Aug 15, 2025 -
`missing_inline_in_public_items` not controllable on individual default trait method
#15491 opened
Aug 14, 2025 -
Lint against `[T].iter().last()` and suggest `[T].last()`
#15487 opened
Aug 14, 2025 -
`regex_creation_in_loops` fires even if a regex compilation is followed by `break`.
#15484 opened
Aug 14, 2025 -
Lint against unnecessary borrow_mut when borrow is enough
#15470 opened
Aug 13, 2025 -
Lintcheck gives a wrong link
#15468 opened
Aug 12, 2025 -
unnecessary_lazy_evaluations could give more targeted suggestion when unwrapping
#15465 opened
Aug 12, 2025 -
No need to ref to function
#15464 opened
Aug 12, 2025 -
Consider renaming `cargo dev setup intellij` command to `cargo dev setup rustrover`
#15463 opened
Aug 12, 2025 -
`unnecessary_fallible_conversions`: Check for unnecessary `from_str` calls where `from` is available
#15456 opened
Aug 11, 2025 -
`allow` specific `unwrap`s with `unwrap_in_result`
#15439 opened
Aug 8, 2025 -
New lint: collapsible `matches!`-es
#15435 opened
Aug 7, 2025 -
Documentation still says that `--fix` selects all targets, even though the behavior was changed
#15433 opened
Aug 7, 2025 -
`too_many_lines` should only highlight the function signature, and not the entire function body
#15430 opened
Aug 7, 2025 -
Detect bitwise negation with `!` for integral types
#15425 opened
Aug 6, 2025 -
New lint: noop_as
#15424 opened
Aug 6, 2025 -
Can it be possible to add functionality for checking only the modified modules?
#15405 opened
Aug 4, 2025 -
result_large_err difficult to suppress selectively
#15404 opened
Aug 4, 2025 -
Allow `explicit_deref_methods` in `Deref` impls
#15392 opened
Aug 2, 2025 -
`semicolon_inside_block` creates what looks like a function call
#15389 opened
Aug 2, 2025 -
`semicolon_inside_block` turns stmts into exprs, breaking attributes
#15388 opened
Aug 2, 2025 -
`unnecessary-operation` type can no longer be inferred
#15381 opened
Jul 31, 2025 -
`semicolon-inside-block` removes parens breaking code
#15380 opened
Jul 31, 2025 -
`equatable-if-let` not stable for consts yet
#15376 opened
Jul 31, 2025 -
Clone of box then dereference should dereference first
#15374 opened
Jul 30, 2025 -
Lint suggestion: `indirect_boxing`
#15373 opened
Jul 30, 2025 -
`incompatible_msrv` does not work with unit tests
#15369 opened
Jul 29, 2025 -
`bool_comparison` triggers twice on the same code
#15367 opened
Jul 29, 2025 -
`min_ident_chars` applies same rules to variables and fn params
#15365 opened
Jul 29, 2025 -
`nonminimal_bool` does not work with `||`
#15364 opened
Jul 29, 2025 -
missing_panics_doc: FP with <div>
#15353 opened
Jul 26, 2025 -
`match_bool` will suggetion will introduce untinitialized binding that still existed in the match arm
#15351 opened
Jul 26, 2025 -
`never_loop` removes label that the replaced loop was attached to (outer label)
#15350 opened
Jul 26, 2025 -
`branches-sharing-code` does not work when the shared references code inside branches
#15347 opened
Jul 26, 2025 -
Providing information about integer type aliases with multiple sizes
#15337 opened
Jul 24, 2025 -
`manual_is_multiple_of` suggests change that could alter behaviour
#15335 opened
Jul 24, 2025 -
warn about code that is aligned without being in a code or pre block
#15334 opened
Jul 24, 2025 -
needless_borrows_for_generic_args incorrectly triggers on `&[]`
#15333 opened
Jul 24, 2025 -
Non-saturating arithmetic on saturating types
#15328 opened
Jul 23, 2025 -
add lint for having a Panics comment when code cannot panic
#15327 opened
Jul 23, 2025 -
manual_is_ascii_check causes error[E0282]: type annotations needed
#15326 opened
Jul 22, 2025 -
Lint when `serde(flatten)` causes a name collision or "shadowed" field
#15324 opened
Jul 21, 2025 -
`Write::write_all` on vec instead of `extend_from_slice`
#15323 opened
Jul 21, 2025 -
`unnecessary_unwrap` false negative of Option variable in struct
#15321 opened
Jul 21, 2025 -
Macros that emit attributes do not trigger at the correct node in `disallowed_macros`
#15312 opened
Jul 18, 2025 -
Failure to correctly apply fixes for clippy::map_entry
#15307 opened
Jul 18, 2025
155 Unresolved conversations
Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.
-
`map_identity`: suggest making the variable mutable when necessary
#15268 commented on
Aug 16, 2025 • 9 new comments -
Do not suggest to use implicit `DerefMut` on `ManuallyDrop` reached through unions
#14387 commented on
Jul 31, 2025 • 7 new comments -
Add lint `long_variable_names`
#14818 commented on
Aug 15, 2025 • 5 new comments -
WIP: New lint: `duplicate_match_guards`
#14986 commented on
Aug 10, 2025 • 2 new comments -
WIP: New lint: `needless_path_new`
#14895 commented on
Aug 7, 2025 • 1 new comment -
fix(manual_assert): use multipart suggestion instead of simple span_suggestion
#15226 commented on
Aug 3, 2025 • 1 new comment -
`explicit_deref_methods` triggering from within macros
#15168 commented on
Aug 11, 2025 • 0 new comments -
`self_named_module_files` implementation is broken
#14697 commented on
Aug 11, 2025 • 0 new comments -
future_not_send unclear about what value is held across an await
#14271 commented on
Aug 12, 2025 • 0 new comments -
Coccinelle files generated by Clippy?
#13516 commented on
Aug 12, 2025 • 0 new comments -
Clippy `string-to-string` `--fix` generates broken code
#15300 commented on
Aug 13, 2025 • 0 new comments -
New lint: reproducible build hazards
#15263 commented on
Aug 14, 2025 • 0 new comments -
`cargo-clippy` doesn't seem to support `--exclude` option like `check`
#9555 commented on
Aug 14, 2025 • 0 new comments -
single_component_path_imports should respect #[allow(unused_imports)]
#9139 commented on
Aug 15, 2025 • 0 new comments -
False alarm with derive_ord_xor_partial_ord
#6219 commented on
Aug 16, 2025 • 0 new comments -
Clippy does not respect rules to allow `uninlined_format_args`
#14694 commented on
Aug 16, 2025 • 0 new comments -
`absolute_paths` can trigger on code produced by a macro
#13920 commented on
Aug 16, 2025 • 0 new comments -
Incorrect clippy::derivable_impls in the presence of conditional compilation
#13160 commented on
Aug 16, 2025 • 0 new comments -
`needless_pass_by_ref_mut` should not trigger when values derived from the `&mut` are used in an unsafe block
#13172 commented on
Aug 17, 2025 • 0 new comments -
New lint: clone on arguments taken by reference
#2074 commented on
Aug 17, 2025 • 0 new comments -
Rust API Guideline: Functions minimize assumptions about parameters by using generics
#1794 commented on
Aug 17, 2025 • 0 new comments -
redundant_closure suggests wrong fix when the function being called is not Copy
#1608 commented on
Aug 17, 2025 • 0 new comments -
Rework the suspicious formatting lints.
#12980 commented on
Jul 20, 2025 • 0 new comments -
`clippy::non_canonical_partial_ord_impl` warns for canonical forwarding implementation
#14149 commented on
Jul 18, 2025 • 0 new comments -
Why is `use_self` deprecated?
#11960 commented on
Aug 9, 2025 • 0 new comments -
unnecessary_cast: does not handle `std::ptr::null{_mut}`
#11912 commented on
Aug 9, 2025 • 0 new comments -
redundant_closure lint causes a compile error when applied as is
#11604 commented on
Aug 9, 2025 • 0 new comments -
`clippy` was not able to apply suggested fixes
#11598 commented on
Aug 9, 2025 • 0 new comments -
[feature request] Auto-fix for `extra_unused_lifetimes`
#13612 commented on
Aug 9, 2025 • 0 new comments -
Display lints which are blocked by the configured MSRV
#13416 commented on
Aug 9, 2025 • 0 new comments -
`clippy::clone_on_copy` following recommendation on lock guards can lead to dead locks
#12957 commented on
Aug 9, 2025 • 0 new comments -
Changed lint name refers to lint uplifted into rustc
#11654 commented on
Aug 9, 2025 • 0 new comments -
Panic when running `cargo clippy --all-targets` after protobuf change
#11542 commented on
Aug 9, 2025 • 0 new comments -
`clippy::wildcard_dependencies` message doesn't indicate the source file with the error
#11409 commented on
Aug 9, 2025 • 0 new comments -
`std::thread::park` is a better suggestion for fixing `clippy::empty_loop`
#11388 commented on
Aug 9, 2025 • 0 new comments -
Bug report: thread 'rustc' panicked at 'forcing query with already existing `DepNode`
#11155 commented on
Aug 9, 2025 • 0 new comments -
Configuring clippy in Cargo.toml missing from documentation?
#12164 commented on
Aug 9, 2025 • 0 new comments -
`clippy::main_recursion` tests seem to be testing nothing anymore
#11034 commented on
Aug 9, 2025 • 0 new comments -
[Clippy command line] Add ignore flag (e.g., for directories or crate names).
#10957 commented on
Aug 9, 2025 • 0 new comments -
False "missing_const_in_fn" for a function that consumes `self`
#8874 commented on
Aug 10, 2025 • 0 new comments -
Lint `*Error` types that don't implement `std::error::Error`
#1291 commented on
Aug 10, 2025 • 0 new comments -
Docs for `let_underscore_untyped` unclear
#10867 commented on
Aug 10, 2025 • 0 new comments -
Add ifs_as_logical_ops lint
#14904 commented on
Aug 4, 2025 • 0 new comments -
Automatically set MSRV for code under `#[cfg(version)]`
#14940 commented on
Aug 17, 2025 • 0 new comments -
Note that using `enumerate()` will swap the arguments
#14969 commented on
Jul 28, 2025 • 0 new comments -
Suggest naming types before using explicit type names
#14996 commented on
Jul 28, 2025 • 0 new comments -
add new lint: `rest_when_destructuring_struct`
#15000 commented on
Aug 17, 2025 • 0 new comments -
Get the block content from the proper context
#15014 commented on
Jul 25, 2025 • 0 new comments -
New lint: `concealed_obvious_default`
#15037 commented on
Aug 17, 2025 • 0 new comments -
Fix `redundant_closure` suggests wrongly with deref overload
#15077 commented on
Aug 13, 2025 • 0 new comments -
Add new lints: `const_sized_chunks_exact`, `const_sized_chunks_exact_mut`, and `const_sized_windows`
#15097 commented on
Aug 2, 2025 • 0 new comments -
Fix `large_stack_frames` FP on compiler generated targets
#15101 commented on
Aug 11, 2025 • 0 new comments -
handle another type of collapsible if-statement
#15104 commented on
Aug 17, 2025 • 0 new comments -
[WIP] Support lint level configuration in clippy.toml
#15155 commented on
Aug 9, 2025 • 0 new comments -
Fix `as_ptr_cast_mut` FP when `self` is not mutable
#15266 commented on
Aug 14, 2025 • 0 new comments -
`clippy_dev`: changes to parsing code
#15270 commented on
Aug 17, 2025 • 0 new comments -
Split methods pass into a new crate take 2
#15280 commented on
Aug 17, 2025 • 0 new comments -
Split loops pass into a new crate
#15291 commented on
Aug 17, 2025 • 0 new comments -
Split matches pass into a new crate
#15292 commented on
Aug 17, 2025 • 0 new comments -
Split casts pass into a new crate
#15293 commented on
Aug 17, 2025 • 0 new comments -
Rework `empty_with_brackets`
#13063 commented on
Jul 21, 2025 • 0 new comments -
Rewrite config parsing for better span support
#13084 commented on
Jul 22, 2025 • 0 new comments -
add `default_mismatches_new` lint
#14234 commented on
Aug 17, 2025 • 0 new comments -
fix `option_if_let_else` when `Err` variant is ignored
#14429 commented on
Aug 17, 2025 • 0 new comments -
[Minor perf] Avoid unnecessary allocations
#14509 commented on
Aug 17, 2025 • 0 new comments -
Lint to stable/beta lint docs page in diagnostics
#14547 commented on
Aug 17, 2025 • 0 new comments -
Convert `redundant_clone` to an analysis pass take 2
#14599 commented on
Jul 26, 2025 • 0 new comments -
Add relative_path_in_macro_definition lint (#14472) #14645
#14648 commented on
Jul 30, 2025 • 0 new comments -
Add data structures used by `redundant_clone`
#14672 commented on
Jul 23, 2025 • 0 new comments -
Add the MIR utils used by `redundant_clone`
#14683 commented on
Jul 23, 2025 • 0 new comments -
Soft rename `clippy::all` to `clippy::default`
#14689 commented on
Aug 17, 2025 • 0 new comments -
Snippet rework
#14724 commented on
Jul 20, 2025 • 0 new comments -
Rework `missing_docs_in_private_items`
#14741 commented on
Jul 19, 2025 • 0 new comments -
Rework `module_inception`
#14753 commented on
Aug 17, 2025 • 0 new comments -
Add `clippy::self_only_used_in_recursion` lint
#14787 commented on
Aug 11, 2025 • 0 new comments -
`parsed_string_literals`: new lint
#14794 commented on
Jul 28, 2025 • 0 new comments -
Verify that versions in the changelog match the lint definitions
#14821 commented on
Aug 17, 2025 • 0 new comments -
fix(or_fun_call): respect MSRV for unwrap_or_default suggestion
#14885 commented on
Aug 17, 2025 • 0 new comments -
Warn against having multiple `impl` blocks for the same struct and with the same bounds(?)
#8714 commented on
Jul 30, 2025 • 0 new comments -
New lint: wildcard pattern in let
#4090 commented on
Aug 2, 2025 • 0 new comments -
Should `cast_{un,}signed()` be considered an `as` cast for linting purposes?
#14975 commented on
Aug 3, 2025 • 0 new comments -
Additions to float_cmp check
#1683 commented on
Aug 3, 2025 • 0 new comments -
Warn on large amounts of string matches
#1482 commented on
Aug 3, 2025 • 0 new comments -
`too_many_arguments` should ignore functions called `new`
#1576 commented on
Aug 3, 2025 • 0 new comments -
lint traits with only one implementor
#1636 commented on
Aug 3, 2025 • 0 new comments -
Lint against Sync return values from un-Sync types
#1842 commented on
Aug 3, 2025 • 0 new comments -
Suggest _[x..][..n] instead of _[x..x+n]
#2272 commented on
Aug 3, 2025 • 0 new comments -
Suggest raw identifiers for near-spellings of existing keywords
#2564 commented on
Aug 3, 2025 • 0 new comments -
New Lint: *mut used
#2490 commented on
Aug 3, 2025 • 0 new comments -
duplicate variables
#2318 commented on
Aug 3, 2025 • 0 new comments -
Feature request: Comprehensive check for conflicting map keys in Serde
#2548 commented on
Aug 3, 2025 • 0 new comments -
Suggest replacing simple loops with specialized folds
#2401 commented on
Aug 3, 2025 • 0 new comments -
Allow blacklisted names in tests
#2198 commented on
Aug 3, 2025 • 0 new comments -
Allow some way of marking lints as TODO
#2158 commented on
Aug 3, 2025 • 0 new comments -
mut_mut complains when borrowing from a slice of mutable references
#13021 commented on
Aug 3, 2025 • 0 new comments -
lint missing trait impls for Cow
#2055 commented on
Aug 3, 2025 • 0 new comments -
Lint macro definitions that don't allow trailing commas
#1848 commented on
Aug 3, 2025 • 0 new comments -
Suggest to replace `int_as_float.log{|2|10}().floor() as u32` with `int.ilog{|2|10}()`
#13699 commented on
Jul 18, 2025 • 0 new comments -
boolean to integer conversion multiple passes and error
#15299 commented on
Jul 19, 2025 • 0 new comments -
New Lint: No recursion without tail calls
#1678 commented on
Jul 20, 2025 • 0 new comments -
Use `write_str` instead of `write!` or `write_fmt` when format has no args
#12240 commented on
Jul 20, 2025 • 0 new comments -
`div_ceil` does not yield optimal code for unsigned const divisor
#15322 commented on
Jul 21, 2025 • 0 new comments -
unnecessary_to_owned causes type mismatch
#8929 commented on
Jul 22, 2025 • 0 new comments -
Lint against Arc<impl Copy>
#13237 commented on
Jul 22, 2025 • 0 new comments -
Propose fix for `cast_sign_loss` and `cast_possible_wrap`
#14150 commented on
Jul 22, 2025 • 0 new comments -
`cargo clippy`: Provides confusing help on wrong usage
#11676 commented on
Jul 23, 2025 • 0 new comments -
[TRACKING] Highlighted issues for the feature freeze
#15086 commented on
Jul 23, 2025 • 0 new comments -
Unexpected panic in rustc_query_system while running 'x clippy'
#15338 commented on
Jul 24, 2025 • 0 new comments -
Suggest trait implementations for references/boxes
#2258 commented on
Jul 24, 2025 • 0 new comments -
`unnested-or-patterns` `union` binding no longer usable
#15219 commented on
Jul 25, 2025 • 0 new comments -
suggest `== Some(` for `is_some_and` if possible
#14713 commented on
Jul 25, 2025 • 0 new comments -
Match Allows Multiple Identical as i32 Statements Without Warning
#14427 commented on
Jul 27, 2025 • 0 new comments -
IIFE closure extension temporary value
#15290 commented on
Jul 28, 2025 • 0 new comments -
doc_markdown should ignore things which just contain acronyms
#1136 commented on
Jul 28, 2025 • 0 new comments -
Lint for using `LazyLock` in a non-static context
#15295 commented on
Jul 28, 2025 • 0 new comments -
`undocumented_unsafe_blocks` requires incorrect word "SAFETY"
#15161 commented on
Jul 28, 2025 • 0 new comments -
Lint Suboptimal Expression Order
#1193 commented on
Aug 3, 2025 • 0 new comments -
[1.84.0 regression] `#[allow(clippy::disallowed_macros)]` does not work on two-argument `std::panic`
#14017 commented on
Aug 4, 2025 • 0 new comments -
Unsized rvalues now making this lint inaccurate
#3420 commented on
Aug 4, 2025 • 0 new comments -
New Lint: `ptr::write` to `#[repr(packed)]` struct field
#3659 commented on
Aug 4, 2025 • 0 new comments -
Add highfive bot post comment when CI fails
#3568 commented on
Aug 4, 2025 • 0 new comments -
new lint: variable scope that can be reduced
#3429 commented on
Aug 4, 2025 • 0 new comments -
bug: false positive for `literal_string_with_formatting_args` lint
#14363 commented on
Aug 5, 2025 • 0 new comments -
`[allow(clippy::disallowed_macros)]` fails for proc-macro attributes
#13521 commented on
Aug 5, 2025 • 0 new comments -
lint idea: `useless_default_generic_parameters`
#14848 commented on
Aug 6, 2025 • 0 new comments -
[literal_string_with_formatting_args] support for `lazy_format`
#14894 commented on
Aug 6, 2025 • 0 new comments -
clippy::borrowed_box shouldn't warn on return type
#10982 commented on
Aug 6, 2025 • 0 new comments -
[Perf] Most time-consuming lints
#14707 commented on
Aug 6, 2025 • 0 new comments -
result_large_err should be relative to the Ok variant
#10211 commented on
Aug 7, 2025 • 0 new comments -
Include simple fractions in approx_constant
#15248 commented on
Aug 7, 2025 • 0 new comments -
`cognitive_complexity` lint includes code expanded from macro in calculated complexity
#14417 commented on
Aug 7, 2025 • 0 new comments -
`needless_pass_by_value` lint does not trigger on `async fn`
#15136 commented on
Aug 7, 2025 • 0 new comments -
`option_if_let_else` misses lint on `mut` version of function
#8967 commented on
Aug 8, 2025 • 0 new comments -
suspicious-operation-groupings generates a false positive, suggested code doesn't even compile
#7086 commented on
Aug 8, 2025 • 0 new comments -
mistyped_literal_suffixes triggered for any integer that ends with _8 _16 _32 _64
#8715 commented on
Aug 8, 2025 • 0 new comments -
Clippy pedantic for f64 as u64
#8601 commented on
Aug 8, 2025 • 0 new comments -
lint suggestion: suggest use of Result::map/Result::and_then
#2271 commented on
Aug 3, 2025 • 0 new comments -
Cyclomatic Complexity should not count code in `debug_assert`
#2249 commented on
Aug 3, 2025 • 0 new comments -
new lint: suggest using iterator instead of casting iterator to vector end using vector, in simple cases
#2723 commented on
Aug 3, 2025 • 0 new comments -
Lint against unbound lifetimes
#1843 commented on
Aug 3, 2025 • 0 new comments -
Doesn't work with custom rustc path
#2765 commented on
Aug 3, 2025 • 0 new comments -
New lint: Detect Ok(foo?) patterns and suggest .map_err(From::from) instead.
#2450 commented on
Aug 3, 2025 • 0 new comments -
clippy-internal lint suggestions
#1376 commented on
Aug 3, 2025 • 0 new comments -
`undocumented_unsafe_blocks` should attempt to detect typos
#15038 commented on
Aug 3, 2025 • 0 new comments -
Overzealous `uninlined_format_args`
#14686 commented on
Aug 3, 2025 • 0 new comments -
New lint: suggest `is_ok()` when using wild pattern in both Ok and Err
#3290 commented on
Aug 3, 2025 • 0 new comments -
useless_let_if_seq should not emit a warning if multiple assignments happen
#2749 commented on
Aug 3, 2025 • 0 new comments -
unusual_byte_groupings triggers for binary literals
#11749 commented on
Aug 4, 2025 • 0 new comments -
Potentially redundant/upliftable lints
#2846 commented on
Aug 4, 2025 • 0 new comments -
Lint for useless tuple binding.
#2852 commented on
Aug 4, 2025 • 0 new comments -
new lint: unneccessary iterator conversion: vec -> iter -> reverse -> collect -> vec
#2970 commented on
Aug 4, 2025 • 0 new comments -
new lint: double reverse
#3416 commented on
Aug 4, 2025 • 0 new comments -
new lint: pointless match
#3337 commented on
Aug 4, 2025 • 0 new comments -
new lint: find unused method results (take '&mut self' into account)
#3061 commented on
Aug 4, 2025 • 0 new comments -
new lint: Unexpected double indirection
#3154 commented on
Aug 4, 2025 • 0 new comments