Skip to content

Stabilize the avx512 target features #138940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

Stabilize the avx512 target features #138940

merged 2 commits into from
May 18, 2025
+54 −64

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Mar 25, 2025 •
edited
Loading

This PR stabilizes the AVX512 target features - see this comment.

Tracking Issue - #44839

The target feature UI tests have been changed to x87 (chosen because this is very unlikely to stablize ever, please comment if some other feature will be better)

related: #111137

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@sayantn

This comment was marked as resolved.

Sign in to view
@sayantn sayantn force-pushed the stabilize-avx512 branch 2 times, most recently from 1be9f75 to 94d0e36 Compare March 25, 2025 19:51
@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@sayantn sayantn mentioned this pull request Mar 25, 2025
Merged
@Amanieu Amanieu added the I-lang-nominated Nominated for discussion during a lang team meeting. label Mar 25, 2025
@Amanieu
Copy link
Member

Amanieu commented Mar 25, 2025

Nominating for T-lang FCP. This stabilizes the AVX512 target features which is a per-requisite for stabilizing the AVX-512 intrinsics tracked in #111137.

@Amanieu Amanieu added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 25, 2025
@ehuss
Copy link
Contributor

ehuss commented Mar 26, 2025

Can you also send a PR to update https://github.com/rust-lang/reference/blob/master/src/attributes/codegen.md#x86-or-x86_64?

@sayantn sayantn mentioned this pull request Apr 2, 2025
Open
@sayantn sayantn force-pushed the stabilize-avx512 branch from 94d0e36 to a3c822a Compare April 3, 2025 12:13
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu Amanieu mentioned this pull request Apr 8, 2025
Open
2 tasks
Amanieu
Amanieu approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These features are for the various AVX512 sub-features. We have already stabilized some of these names in is_x86_feature_detected! so the language level name should match.

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 17, 2025
@rfcbot
Copy link
Collaborator

rfcbot commented May 17, 2025

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@traviscross
Copy link
Contributor

r? traviscross

With FCP complete, the Reference PR approved, and with the diff here looking OK to @Amanieu and myself, this is good to go modulo:

DO NOT MERGE now, because the runtime detection for 5 features are guarded on avx512_target_feature, so rust-lang/stdarch#1757 has a temporary fix which changes the feature name of these. We need to FCP these together with all the AVX512 target features, after that and merge of rust-lang/stdarch#1760, we can again do a stdarch update and merge this.

@sayantn, let us know when this is OK to merge.

@rustbot author

@rustbot rustbot assigned traviscross and unassigned nikomatsakis May 17, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@sayantn
Copy link
Contributor Author

sayantn commented May 17, 2025

@traviscross @Amanieu is the feature detection part of T-lang or T-libs-api.

@Amanieu
Copy link
Member

Amanieu commented May 17, 2025

rust-lang/stdarch#1760 can land as soon as this FCP is complete. Then you can update the stdarch submodule in this PR and it can itself be merged.

@sayantn
Copy link
Contributor Author

sayantn commented May 17, 2025

@Amanieu the FCP on this PR is complete, so stdarch#1760 can be merged now, right?

@sayantn sayantn force-pushed the stabilize-avx512 branch from 2a8cf18 to 2898680 Compare May 18, 2025 05:44
@sayantn
Copy link
Contributor Author

sayantn commented May 18, 2025

@traviscross finally this PR is ready for merge, just waiting for CI

@traviscross
Copy link
Contributor

Thanks for pushing this along.

@bors r=Amanieu,traviscross rollup

@bors
Copy link
Collaborator

bors commented May 18, 2025

📌 Commit 2898680 has been approved by Amanieu,traviscross

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 18, 2025
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#138940 - sayantn:stabilize-avx512, r=Amanie…
6d4754f 
…u,traviscross

Stabilize the avx512 target features

This PR stabilizes the AVX512 target features - see [this comment](rust-lang#111137 (comment)).

Tracking Issue - rust-lang#44839

The target feature UI tests have been changed to `x87` (chosen because this is very unlikely to stablize ever, please comment if some other feature will be better)

related: rust-lang#111137
@fmease fmease mentioned this pull request May 18, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141228 - fmease:rollup-yqpyhpz, r=fmease
53f7119 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#127013 (Add `f16` formatting and parsing)
 - rust-lang#138940 (Stabilize the avx512 target features)
 - rust-lang#140154 (Cygwin support in rustc)
 - rust-lang#140490 (split `asm!` parsing and validation)
 - rust-lang#140628 (std: stop using TLS in signal handler)
 - rust-lang#140746 (name resolution for guard patterns)
 - rust-lang#140926 (Return value of coroutine_layout fn changed to Result with LayoutError)
 - rust-lang#141127 (bump windows crate for compiler,bootstrap and tools)
 - rust-lang#141214 (Miri subtree update)
 - rust-lang#141218 (gvn: avoid creating overlapping assignments)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request May 18, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#141232 - fmease:rollup-qr9mobf, r=fmease
4455c89 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#138940 (Stabilize the avx512 target features)
 - rust-lang#140490 (split `asm!` parsing and validation)
 - rust-lang#140628 (std: stop using TLS in signal handler)
 - rust-lang#140746 (name resolution for guard patterns)
 - rust-lang#140926 (Return value of coroutine_layout fn changed to Result with LayoutError)
 - rust-lang#141127 (bump windows crate for compiler,bootstrap and tools)
 - rust-lang#141214 (Miri subtree update)
 - rust-lang#141218 (gvn: avoid creating overlapping assignments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2f6811e into rust-lang:master May 18, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@rust-timer
Unrolled build for rust-lang#138940
327d736 
Rollup merge of rust-lang#138940 - sayantn:stabilize-avx512, r=Amanieu,traviscross

Stabilize the avx512 target features

This PR stabilizes the AVX512 target features - see [this comment](rust-lang#111137 (comment)).

Tracking Issue - rust-lang#44839

The target feature UI tests have been changed to `x87` (chosen because this is very unlikely to stablize ever, please comment if some other feature will be better)

related: rust-lang#111137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@Amanieu Amanieu Amanieu approved these changes

@traviscross traviscross traviscross approved these changes

Assignees

@traviscross traviscross

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-lang Relevant to the language team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.