Skip to content

Use non-2015 edition paths in tests that do not test for their resolution #141960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jun 3, 2025

This allows for testing these tests on editions other than 2015

Follow up to #141888

…tion

This allows for testing these tests on editions other than 2015
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit eae7fe1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025
@rustbot rustbot assigned compiler-errors and unassigned SparrowLii Jun 3, 2025
chenyukang added a commit to chenyukang/rust that referenced this pull request Jun 4, 2025
…er-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to rust-lang#141888
bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 6 pull requests

Successful merges:

 - #141250 (add s390x z17 target features)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141959 (Add more missing 2015 edition directives)
 - #141960 (Use non-2015 edition paths in tests that do not test for their resolution)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee
Copy link
Member

Checking if this caused #141995 (comment) by somehow altering a path that was important.

@bors r-
@bors2 try

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 4, 2025

⌛ Trying commit eae7fe1 with merge e66c706

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 4, 2025
Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to #141888

try-job: i686-msvc-1
@workingjubilee
Copy link
Member

I guess it's okay!

@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit eae7fe1 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025
@workingjubilee
Copy link
Member

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit eae7fe1 has been approved by compiler-errors

It is now in the queue for this repository.

@rust-bors
Copy link

rust-bors bot commented Jun 4, 2025

☀️ Try build successful (CI)
Build commit: e66c706 (e66c7063fb550ebd1acb2b198cf9089ea9fe9146)

@chenyukang
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2025
@chenyukang
Copy link
Member

sorry, replied wrong PR.

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit eae7fe1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025
bors added a commit that referenced this pull request Jun 5, 2025
Rollup of 11 pull requests

Successful merges:

 - #141890 (Add link to correct documentation in htmldocck.py)
 - #141932 (Fix for async drop inside async gen fn)
 - #141960 (Use non-2015 edition paths in tests that do not test for their resolution)
 - #141968 (Run wfcheck in one big loop instead of per module)
 - #141969 (Triagebot: Remove `assign.users_on_vacation`)
 - #141985 (Ensure query keys are printed with reduced queries)
 - #141999 (Visit the ident in `PreciseCapturingNonLifetimeArg`.)
 - #142005 (Change `tag_field` to `FieldIdx` in `Variants::Multiple`)
 - #142017 (Fix incorrect use of "recommend" over "recommended")
 - #142024 (Don't refer to 'this tail expression' in expansion.)
 - #142025 (Don't refer to 'local binding' in extern macro.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit be2d382 into rust-lang:master Jun 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 5, 2025
rust-timer added a commit that referenced this pull request Jun 5, 2025
Rollup merge of #141960 - ferrocene:lw/2015-paths2, r=compiler-errors

Use non-2015 edition paths in tests that do not test for their resolution

This allows for testing these tests on editions other than 2015

Follow up to #141888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants