redesign stage 0 std follow-ups part2 #142002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
rustbot
added
S-waiting-on-review
Signed-off-by: onur-ozkan <[email protected]>
rustbot
added
the
A-testsuite
|
Testing locally |
jieyouxu
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Thanks
Testing
nnethercote's minimal bootstrap.toml
[rust]
download-rustc = false
./x check: OK./x check rustdoc: OK
[rust]
download-rustc = true
./x check: OK./x check rustdoc: OK
./x check on compiler
No bootstrap.toml:
./x check compiler: OK./x check rustc: OK
[rust]
download-rustc = true
./x check: OK, already checked earlier./x check compiler: OK./x check rustc: OK
./x test library
profile = "library" # <- with `download-rustc = "if-unchanged"` default./x test library/: OK
|
@bors r+ rollup p=10 (contributor workflow) |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 4, 2025
redesign stage 0 std follow-ups part2 Fixes three bugs: 1. `x check` fails when run on rustdoc without `download-rustc` enabled. (1st commit) 2. `x check` fails when run on the compiler with `download-rustc` enabled. (2nd commit) 3. `x test library` fails with `download-rustc` enabled. (3rd commit) Fixes rust-lang#142018 (case 1) Fixes rust-lang#141983 (case 3)
bors
added a commit
that referenced
this pull request
Jun 4, 2025
Rollup of 9 pull requests Successful merges: - #141271 (Streamline some attr parsing APIs) - #141570 (Fix incorrect eq_unspanned in TokenStream) - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them) - #141893 (remove `f16: From<u16>`) - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if) - #141939 (exact_div: add tests) - #141959 (Add more missing 2015 edition directives) - #142002 (redesign stage 0 std follow-ups part2) - #142007 (Improve some `Visitor` comments.) r? `@ghost` `@rustbot` modify labels: rollup
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 61413ae (parent) -> df8102f (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard df8102fe5f24f28a918660b0cd918d7331c3896e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jun 4, 2025
To prepare for merging from rust-lang/rust, set the version file to:
df8102f Auto merge of rust-lang#142002 - onur-ozkan:follow-ups2, r=jieyouxu
|
Finished benchmarking commit (df8102f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -4.6%, secondary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 749.479s -> 749.348s (-0.02%) |
kiseitai3
pushed a commit
to kiseitai3/rust
that referenced
this pull request
Jun 6, 2025
To prepare for merging from rust-lang/rust, set the version file to:
df8102f Auto merge of rust-lang#142002 - onur-ozkan:follow-ups2, r=jieyouxu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three bugs:
x checkfails when run on rustdoc withoutdownload-rustcenabled. (1st commit)x checkfails when run on the compiler withdownload-rustcenabled. (2nd commit)x test libraryfails withdownload-rustcenabled. (3rd commit)Fixes #142018 (case 1)
Fixes #141983 (case 3)