Skip to content

add new config: rust.download_rustc_incompatibility_check #142055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add new config: rust.download_rustc_incompatibility_check #142055

wants to merge 3 commits into from
+17 −1

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Jun 5, 2025 •
edited by rustbot
Loading

Unlike #142054, this adds a config-based approach to control download-rustc incompatibility check.

Fixes #142054

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan onur-ozkan mentioned this pull request Jun 5, 2025
Open
@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2025

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@jieyouxu
Copy link
Member

jieyouxu commented Jun 5, 2025

Waiting on discussions to settle on #t-infra/bootstrap > Settings are incompatible with download-rustc.

@rustbot label -S-waiting-on-review +S-waiting-on-team

@rustbot rustbot added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
@bors
Copy link
Collaborator

bors commented Jun 5, 2025

☔ The latest upstream changes (presumably #142070) made this pull request unmergeable. Please resolve the merge conflicts.

@onur-ozkan
Copy link
Member Author

I will hold rebasing until we decide to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onur-ozkan @rustbot @jieyouxu @bors