rework #[naked] attribute parser
#142493
Merged
rework #[naked] attribute parser
#142493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
9 tasks
jdonszelmann
force-pushed
the
naked
branch
2 times, most recently
from
48b6d12 to
78a8771
Compare
This comment has been minimized.
This comment has been minimized.
|
cc: @folkertdev this might interest you |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #142795) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
|
Some changes occurred in compiler/rustc_codegen_ssa |
rustbot
added
the
S-waiting-on-review
oli-obk
reviewed
Jun 21, 2025
oli-obk
reviewed
Jun 21, 2025
oli-obk
reviewed
Jun 21, 2025
|
@rustbot ready |
|
☔ The latest upstream changes (presumably #142878) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
reviewed
Jun 23, 2025
oli-obk
approved these changes
Jun 23, 2025
|
rebasd on master @bors r=oli-obk |
bors
added
S-waiting-on-bors
|
@bors rollup=iffy |
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Jun 23, 2025
rework `#[naked]` attribute parser r? `@oli-obk`
This was referenced Jun 23, 2025
bors
added a commit
that referenced
this pull request
Jun 23, 2025
Rollup of 5 pull requests Successful merges: - #142493 (rework `#[naked]` attribute parser) - #142636 (bootstrap.example.toml: use less contextual format) - #142822 (Make `PartialEq` a `const_trait`) - #142892 (Fix ICE on debug builds where lints are delayed on the crate root) - #142904 (notify me when rdg is touched) Failed merges: - #142827 (Move error code explanation removal check into tidy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 23, 2025
Rollup merge of #142493 - jdonszelmann:naked, r=oli-obk rework `#[naked]` attribute parser r? ``@oli-obk``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 25, 2025
Port `#[track_caller]` to the new attribute system r? `@oli-obk` depends on rust-lang#142493 Closes rust-lang#142783 (didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 25, 2025
Port `#[track_caller]` to the new attribute system r? ``@oli-obk`` depends on rust-lang#142493 Closes rust-lang#142783 (didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)
rust-timer
added a commit
that referenced
this pull request
Jun 25, 2025
Rollup merge of #142825 - jdonszelmann:track-caller, r=oli-obk Port `#[track_caller]` to the new attribute system r? ``@oli-obk`` depends on #142493 Closes #142783 (didn't add a test for this, this situation should simply never come up again, the code was simply wrong. lmk if I should add it, but it won't test something very useful)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk