Skip to content

Port #[link] to the new attribute parsing infrastructure #143193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonathanBrouwer
Copy link
Contributor

Ports link to the new attribute parsing infrastructure for #131229 (comment)

This rework is not yet finished, it is blocked on the cfg attribute being finished, since link takes a cfg attribute as argument

@rustbot blocked

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jun 29, 2025
Signed-off-by: Jonathan Brouwer <[email protected]>
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
tidy check
Checking tidy rustdoc_json...
Running eslint on rustdoc JS files
`rustdoc-json-types` was not modified.
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_unused_multiple` appears before `attr_parsing_as_needed_compatibility`, but is alphabetically later than it
run `./x.py test tidy --bless` to sort the file correctly
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_not_profiler_runtime` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_fail_write_file` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_target_not_installed` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_link_ordinal_raw_dylib` is not used
tidy error: /checkout/compiler/rustc_metadata/messages.ftl: message `metadata_link_arg_unstable` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_cannot_find_crate` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_bad_panic_strategy` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_cant_find_crate` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_conflicting_global_alloc` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_help_fix_l_missed` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_install_missing_components` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_rlib_required` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_prev_alloc_error_handler` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_failed_create_encoded_metadata` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_failed_create_tempdir` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_dep_rustc_driver` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_extern_location_not_file` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_unknown_target_modifier_unsafe_allowed` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_multiple_candidates` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_target_no_std_support` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_help_fix_r_missed` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_transitive_needs_dep` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_link_mod_override` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_required_panic_strategy` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_prev_global_alloc` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_multiple_global_alloc` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_missing_native_library` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_binary_output_to_tty` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_non_ascii_name` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_failed_create_file` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_dep_multiple` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_two_panic_runtimes` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_multiple_renamings` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_fail_create_file_encoder` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_renaming_no_link` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_empty_renaming_target` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_async_drop_types_in_dependency` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_raw_dylib_unsupported_abi` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_dl_error` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_l_missed` is not used
tidy error: /checkout/compiler/rustc_metadata/messages.ftl: message `metadata_link_cfg_unstable` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_dep_not_static` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_help_fix` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_location_unknown_type` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_found_crate_versions` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_compiler_missing_profiler` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_symbol_conflicts_current` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_stable_crate_id_collision` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_not_compiler_builtins` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_multiple_alloc_error_handler` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_help_allow` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_std_required` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_newer_crate_version` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_lib_framework_apple` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_consider_adding_std` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_conflicting_alloc_error_handler` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_extern_location_not_exist` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_target_modifiers_r_missed` is not used
tidy error: /checkout/compiler/rustc_metadata/messages.ftl: message `metadata_raw_dylib_elf_unstable` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_found_staticlib` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_panic_in_drop_strategy` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_full_metadata_not_found` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_only_provide_library_name` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_rustc_lib_required` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_failed_write_error` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_invalid_meta_files` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_crate_not_panic_runtime` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_global_alloc_required` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_lib_required` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_consider_building_std` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_crate_with_triple` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_lib_filename_form` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_failed_copy_to_stdout` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_incompatible_rustc` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_no_panic_strategy` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_wasm_c_abi` is not used
tidy error: /checkout/compiler/rustc_attr_parsing/messages.ftl: message `attr_parsing_consider_downloading_target` is not used
No error code explanation was removed!
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_attr_data_structures/src/attributes.rs:254: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_attr_parsing/src/attributes/link_attrs.rs:171: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_metadata/src/native_libs.rs:255: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_passes/src/check_attr.rs:210: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_attr_data_structures/src/attributes.rs:374: line not in alphabetical order
##[error]tidy error: /checkout/compiler/rustc_attr_parsing/src/lib.rs:83: line not in alphabetical order
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.1.1)
linting python files
All checks passed!
checking python file formatting
28 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:16
  local time: Sun Jun 29 13:42:43 UTC 2025
  network time: Sun, 29 Jun 2025 13:42:43 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

☔ The latest upstream changes (presumably #143233) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants