Fix unused_parens false positive #143698
Merged
Fix unused_parens false positive #143698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
| #![allow(warnings)] | ||
| trait MyTrait {} | ||
|
|
||
| fn foo(_: Box<dyn FnMut(&mut u32) -> &mut (dyn MyTrait) + Send + Sync>) {} |
There was a problem hiding this comment.
How does this behave with dyn FnMut(&()) -> &(dyn Trait) (i.e. one bound that is parenthesized)?
There was a problem hiding this comment.
I've added that case to the test: We continue to emit a warning.
lcnr
reviewed
Jul 23, 2025
compiler/rustc_lint/src/unused.rs
Outdated
Comment on lines
1339
to
1351
| let own_constraint = self.in_no_bounds_pos.get(&ty.id).copied(); | ||
| let constraint = own_constraint.unwrap_or(NoBoundsException::OneBound); | ||
| self.in_no_bounds_pos.insert(mut_ty.ty.id, constraint); |
There was a problem hiding this comment.
in a sense we want tis to be constraint = own_constraint.max(NoBoundsException::OneBound) where as NoBoundsException::OneBound is currently the minimal value this is correct?
I would feel safer if we were to make this a match on own_constraint or add a NoBoundsException.merge function or sth 🤔
There was a problem hiding this comment.
in a sense we want tis to be
constraint=own_constraint.max(NoBoundsException::OneBound)where asNoBoundsException::OneBoundis currently the minimal value this is correct?
Correct.
I would feel safer if we were to make this a match on
own_constraintor add aNoBoundsException.mergefunction or sth 🤔
I see where you're coming from. I went with the match because 1) I don't see this sprawling and 2) the Option makes the alternatives a bit "messy". Happy to take this any other direction though. 🙂
This comment has been minimized.
This comment has been minimized.
benschulz
force-pushed
the
unused-parens-2
branch
from
9655a85 to
307f664
Compare
|
thx, sorry for the slow review! @bors r=lcnr,compiler-errors rollup |
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 26, 2025
…compiler-errors Fix unused_parens false positive Resolves rust-lang#143653. The "no bounds exception" was indiscriminately set to `OneBound` for referents and pointees. However, if the reference or pointer type itself appears in no-bounds position, any constraints it has must be propagated. ```rust // unused parens: not in no-bounds position fn foo(_: Box<(dyn Send)>) {} // unused parens: in no-bounds position, but one-bound exception applies fn bar(_: Box<dyn Fn(&u32) -> &(dyn Send)>) {} // *NOT* unused parens: in no-bounds position, but no exceptions to be made fn baz(_: Box<dyn Fn(&u32) -> &(dyn Send) + Send>) {} ```
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 26, 2025
…compiler-errors Fix unused_parens false positive Resolves rust-lang#143653. The "no bounds exception" was indiscriminately set to `OneBound` for referents and pointees. However, if the reference or pointer type itself appears in no-bounds position, any constraints it has must be propagated. ```rust // unused parens: not in no-bounds position fn foo(_: Box<(dyn Send)>) {} // unused parens: in no-bounds position, but one-bound exception applies fn bar(_: Box<dyn Fn(&u32) -> &(dyn Send)>) {} // *NOT* unused parens: in no-bounds position, but no exceptions to be made fn baz(_: Box<dyn Fn(&u32) -> &(dyn Send) + Send>) {} ```
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 9 pull requests Successful merges: - #140871 (Don't lint against named labels in `naked_asm!`) - #141663 (rustdoc: add ways of collapsing all impl blocks) - #143272 (Upgrade the `fortanix-sgx-abi` dependency) - #143585 (`loop_match`: suggest extracting to a `const` item) - #143698 (Fix unused_parens false positive) - #143859 (Guarantee 8 bytes of alignment in Thread::into_raw) - #144042 (Verify llvm-needs-components are not empty and match the --target value) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144431 (Disable has_reliable_f128_math on musl targets) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 9 pull requests Successful merges: - #140871 (Don't lint against named labels in `naked_asm!`) - #141663 (rustdoc: add ways of collapsing all impl blocks) - #143272 (Upgrade the `fortanix-sgx-abi` dependency) - #143585 (`loop_match`: suggest extracting to a `const` item) - #143698 (Fix unused_parens false positive) - #143859 (Guarantee 8 bytes of alignment in Thread::into_raw) - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - #144412 (Small cleanup: Use LocalKey<Cell> methods more) - #144431 (Disable has_reliable_f128_math on musl targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup merge of #143698 - benschulz:unused-parens-2, r=lcnr,compiler-errors Fix unused_parens false positive Resolves #143653. The "no bounds exception" was indiscriminately set to `OneBound` for referents and pointees. However, if the reference or pointer type itself appears in no-bounds position, any constraints it has must be propagated. ```rust // unused parens: not in no-bounds position fn foo(_: Box<(dyn Send)>) {} // unused parens: in no-bounds position, but one-bound exception applies fn bar(_: Box<dyn Fn(&u32) -> &(dyn Send)>) {} // *NOT* unused parens: in no-bounds position, but no exceptions to be made fn baz(_: Box<dyn Fn(&u32) -> &(dyn Send) + Send>) {} ```
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jul 30, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#140871 (Don't lint against named labels in `naked_asm!`) - rust-lang#141663 (rustdoc: add ways of collapsing all impl blocks) - rust-lang#143272 (Upgrade the `fortanix-sgx-abi` dependency) - rust-lang#143585 (`loop_match`: suggest extracting to a `const` item) - rust-lang#143698 (Fix unused_parens false positive) - rust-lang#143859 (Guarantee 8 bytes of alignment in Thread::into_raw) - rust-lang#144160 (tests: debuginfo: Work around or disable broken tests on powerpc) - rust-lang#144412 (Small cleanup: Use LocalKey<Cell> methods more) - rust-lang#144431 (Disable has_reliable_f128_math on musl targets) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143653.
The "no bounds exception" was indiscriminately set to
OneBoundfor referents and pointees. However, if the reference or pointer type itself appears in no-bounds position, any constraints it has must be propagated.