Allow pretty printing paths with -Zself-profile-events=args
#144462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Kobzol
force-pushed
the
pretty-print-self-profile-args
branch
from
11419b3 to
e9af28e
Compare
|
LGTM, thanks! r=me with CI green. |
lqd
reviewed
Jul 25, 2025
| // | ||
| // Issue: <https://github.com/rust-lang/rust/issues/144457>. | ||
|
|
||
| //@ compile-flags: -Zself-profile -Zself-profile-events=args |
There was a problem hiding this comment.
I believe this is going to put the .mm_profdata files in the root and not in the temporary build test paths.
There was a problem hiding this comment.
Uhh, I'm used to run-make tests that have properly scoped working directories. You're right. Do you know if there's a way in the test header to use some temporary dir? It should be enough to say -Zself-profile=foo.
There was a problem hiding this comment.
Ah, got it, {{build-base}}.
Kobzol
force-pushed
the
pretty-print-self-profile-args
branch
from
e9af28e to
4ef18ab
Compare
|
@bors r=RalfJung |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup of 10 pull requests Successful merges: - #144331 (Disable non_exhaustive_omitted_patterns within matches! macro) - #144376 (Suggest unwrapping when private method name is available in inner type) - #144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually) - #144424 (Allow setting `release-blog-post` label with rustbot) - #144427 (rename ext_tool_checks to extra_checks and use mod.rs) - #144435 (rustc-dev-guide subtree update) - #144448 (Limit defaultness query to impl of trait) - #144462 (Allow pretty printing paths with `-Zself-profile-events=args`) - #144463 (change_tracker: fix a typo) - #144468 (resolve: Do not create `NameResolutions` on access unless necessary) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup merge of #144462 - Kobzol:pretty-print-self-profile-args, r=RalfJung Allow pretty printing paths with `-Zself-profile-events=args` `-Zself-profile-events=args` is pretty heavy and can pretty print a lot of stuff. Rather than hunting down specific cases where this happens, I'd just allow calling `trimmed_def_paths` in this mode. Fixes: #144457 r? `@RalfJung`
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jul 28, 2025
Rollup of 10 pull requests Successful merges: - rust-lang/rust#144331 (Disable non_exhaustive_omitted_patterns within matches! macro) - rust-lang/rust#144376 (Suggest unwrapping when private method name is available in inner type) - rust-lang/rust#144421 (Call `is_parsed_attribute` rather than keeping track of a list of parsed attributes manually) - rust-lang/rust#144424 (Allow setting `release-blog-post` label with rustbot) - rust-lang/rust#144427 (rename ext_tool_checks to extra_checks and use mod.rs) - rust-lang/rust#144435 (rustc-dev-guide subtree update) - rust-lang/rust#144448 (Limit defaultness query to impl of trait) - rust-lang/rust#144462 (Allow pretty printing paths with `-Zself-profile-events=args`) - rust-lang/rust#144463 (change_tracker: fix a typo) - rust-lang/rust#144468 (resolve: Do not create `NameResolutions` on access unless necessary) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Zself-profile-events=argsis pretty heavy and can pretty print a lot of stuff. Rather than hunting down specific cases where this happens, I'd just allow callingtrimmed_def_pathsin this mode.Fixes: #144457
r? @RalfJung