Skip to content

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Aug 1, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 1, 2025
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 1, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 54ade65 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 1, 2025

r? @ghost

@Mark-Simulacrum
Copy link
Member

@bors p=5

This needs to go in before next week.

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 2, 2025

Oh perhaps we should update the rust-forge docs because they don't say to use a p= 🤔 It definitely makes sense to though because rollup=never PRs have a tendency to take a while to get naturally merged

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

⌛ Testing commit 54ade65 with merge 0ccec2e...

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 2, 2025
@Mark-Simulacrum
Copy link
Member

@bors retry

apple runner failed: The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2025
@bors
Copy link
Collaborator

bors commented Aug 2, 2025

⌛ Testing commit 54ade65 with merge a65b04d...

@bors
Copy link
Collaborator

bors commented Aug 2, 2025

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing a65b04d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 2, 2025
@bors bors merged commit a65b04d into rust-lang:master Aug 2, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 2, 2025
Copy link
Contributor

github-actions bot commented Aug 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6d091b2 (parent) -> a65b04d (this PR)

Test differences

Show 3 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a65b04d7c9a1eaf02b62667da1c203c8a07976d9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-arm-linux-musl: 13776.5s -> 5492.5s (-60.1%)
  2. dist-x86_64-illumos: 12774.3s -> 5714.5s (-55.3%)
  3. dist-x86_64-freebsd: 9423.4s -> 4571.1s (-51.5%)
  4. dist-ohos-armv7: 7692.7s -> 3885.7s (-49.5%)
  5. dist-x86_64-musl: 13716.5s -> 7050.4s (-48.6%)
  6. dist-ohos-x86_64: 7743.6s -> 4062.6s (-47.5%)
  7. dist-ohos-aarch64: 7716.3s -> 4114.5s (-46.7%)
  8. dist-x86_64-netbsd: 8248.2s -> 4655.4s (-43.6%)
  9. dist-powerpc64le-linux-musl: 8872.4s -> 5059.4s (-43.0%)
  10. dist-armv7-linux: 8333.5s -> 4891.1s (-41.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a65b04d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.09s -> 466.266s (-0.60%)
Artifact size: 376.98 MiB -> 376.99 MiB (0.00%)

@nikic nikic mentioned this pull request Aug 3, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants