Clippy subtree update #145056

flip1995 · 2025-08-07T15:13:10Z

Cargo.lock update due to clippy version bump

When I first tried contributing to clippy, I encountered the problem that a lot of lint suggestions overlapped with existing lints, so I would spend a bunch of time implementing something only to figure out it wasn't actually needed. The "comparison with existing lints" field should hopefully reduce this somewhat, while not incresing the burden of requesting a new lint too much due to not being mandatory.

Co-authored-by: Philipp Krones <[email protected]>

…ubtree-update

changelog: none

changelog: [`ip_constant`]: fix suggestion when call is inside parentheses like `(Ipv4Addr::new(127, 0, 0, 1))` Very similar to the fix in rust-lang/rust-clippy#15191

Signed-off-by: Jonathan Brouwer <[email protected]>

Fix `duplicated_attributes` lint to detect prefixed attributes like `clippy::lint_name`. Fixes rust-lang/rust-clippy#14942 changelog: [`duplicated_attributes`]: detect duplicated prefixed attributes

…rom a macro

…lang#15355) Closes rust-lang/rust-clippy#15349 changelog: [`empty_structs_with_brackets`] fix wrong suggestions on generics

rust-lang#15345) …rom a macro changelog: [`unnecessary_map_or`]: don't add parens if the parent expr comes from a macro fixes rust-lang/rust-clippy#14714

) Closes rust-lang/rust-clippy#15061 changelog: [`let_unit_value`] fix wrong suggestions for format macros

@samueltardieu

Follow-up of rust-lang/rust-clippy#15208. This PR removes the CSS `bootstrap` dependency which contains 1504 CSS rules and weights 16.1 kB minified. Considering we used less than 50 of these rules, it's quite a waste. So this time, there are minor UI changes: * The "expand/collapse all" buttons icon changed. It now uses the one from font-awesome. It's quite close but not exactly the same. * The layout is slightly different (you need to switch between two tabs to actually see the difference). Before this PR: <img width="719" height="515" alt="image" src="https://github.com/user-attachments/assets/1f067046-4ee9-49ee-bf38-50a8bf9888f2" /> With this PR: <img width="719" height="515" alt="image" src="https://github.com/user-attachments/assets/80331c98-1a1e-418f-b481-5b3f5c276926" /> With this, we will be able to go even further on reducing the page size next. =D This time, the DOM size itself reduced a bit but the difference is too small to be noteworthy. r? @samueltardieu changelog: Remove CSS bootstrap dependency

This limits repeated lookups in pre-checks (to determine if a MSRV should be checked), especially when those require locking up an interner: - The `core` crate is looked up once when creating the lint, instead of comparing the crate name with `sym::core` at every check. - `span.ctxt().outer_expn_data()` is lookup up only once. changelog: none r? blyxyas

Two optimizations have been done when checking for the context in which to apply the lint: - Checking for the mere presence of comments does not require building a `String` with the comment to then check if it is empty and discard it. - Checking for the presence of comment can be done after we have checked that we do have a `if` construct that we intend to lint instead of for every expression.

Two optimizations have been done when checking for the context in which to apply the lint: - Checking for the mere presence of comments does not require building a `String` with the comment to then check if it is empty and discard it. - Checking for the presence of comment can be done after we have checked that we do have a `if` construct that we intend to lint instead of for every expression. changelog: none r? blyxyas

Small typo I found while looking at recent lint requests/issues. changelog: none

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2025-08-07T15:13:18Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Manishearth · 2025-08-07T15:20:40Z

@bors r+ p=1 rollup=never

thanks!

bors · 2025-08-07T15:20:43Z

📌 Commit 770e6f1 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-08-07T17:29:29Z

⌛ Testing commit 770e6f1 with merge 2fd855f...

bors · 2025-08-07T20:37:05Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 2fd855f to master...

github-actions · 2025-08-07T20:40:27Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 321a89b (parent) -> 2fd855f (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2fd855fbfc8239285aa2d596f76a8cc75e17ce02 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 6663.7s -> 3565.5s (-46.5%)
dist-apple-various: 5170.1s -> 3782.4s (-26.8%)
pr-check-2: 2863.1s -> 2253.2s (-21.3%)
aarch64-apple: 7877.4s -> 6339.5s (-19.5%)
pr-check-1: 1755.4s -> 1417.1s (-19.3%)
dist-x86_64-apple: 11646.9s -> 9494.9s (-18.5%)
x86_64-gnu-llvm-20-2: 6542.5s -> 5547.1s (-15.2%)
x86_64-gnu-tools: 3824.2s -> 3307.2s (-13.5%)
x86_64-gnu-llvm-19: 2822.4s -> 2490.2s (-11.8%)
x86_64-rust-for-linux: 2908.2s -> 2576.2s (-11.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-07T21:47:00Z

Finished benchmarking commit (2fd855f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.5%, 0.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.1%, 3.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.2%	[-7.3%, -7.0%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 464.69s -> 465.394s (0.15%)
Artifact size: 377.37 MiB -> 377.41 MiB (0.01%)

smoelius and others added 30 commits May 19, 2025 19:29

Extend implicit_clone to handle to_string calls

8c6eea8

Fix adjacent code

8a9adba

Account for changes from issue 14396

8e5b0cd

Replace string_to_string with char_lit_as_u8 in driver.sh

6cea9cc

fix: iter_on_single_items FP on function pointers

9e9c917

fix: iter_on_single_item FP on let stmt with type annotation

20670f7

fix: let_unit_value suggests wrongly for format macros

31b9de6

Do not autofix comments containing bare CR

0920486

fix: search_is_some suggests wrongly inside macro

222ebd0

fix: match_single_binding wrongly handles scope

ba6485d

fix: match_single_binding suggests wrongly inside binary expr

48df86f

fix collapsable_if when the inner if is in parens

af19ff8

fix collapsable_else_if when the inner if is in parens

58c00f3

Split possible_missing_else from suspicious_else_formatting.

9e50049

fix markdown

a19b46d

Co-authored-by: Philipp Krones <[email protected]>

fix ip_constant when call wrapped in extra parens

0aa92fd

Detect prefixed attributes as duplicated

da66180

Merge commit '1db89a1b1ca87f24bf22d0bad21d14b2d81b3e99' into clippy-s…

5c7418b

…ubtree-update

Get myself back on assignment rotation

03986e6

Get myself back on assignment rotation (rust-lang#15346)

0397819

changelog: none

Deprecate string_to_string

e910c0e

fix ip_constant when call wrapped in extra parens (rust-lang#15339)

f9ab9d0

changelog: [`ip_constant`]: fix suggestion when call is inside parentheses like `(Ipv4Addr::new(127, 0, 0, 1))` Very similar to the fix in rust-lang/rust-clippy#15191

Fix tooling

31b6b66

Signed-off-by: Jonathan Brouwer <[email protected]>

Detect prefixed attributes as duplicated (rust-lang#15212)

651ca33

Fix `duplicated_attributes` lint to detect prefixed attributes like `clippy::lint_name`. Fixes rust-lang/rust-clippy#14942 changelog: [`duplicated_attributes`]: detect duplicated prefixed attributes

fix: empty_structs_with_brackets suggests wrongly on generics

c78f3ae

fix: unnecessary_map_or don't add parens if the parent expr comes f…

81fc227

…rom a macro

Fix empty_structs_with_brackets suggests wrongly on generics (rust-…

f126db4

…lang#15355) Closes rust-lang/rust-clippy#15349 changelog: [`empty_structs_with_brackets`] fix wrong suggestions on generics

fix: unnecessary_map_or don't add parens if the parent expr comes f… (

3174c05

rust-lang#15345) …rom a macro changelog: [`unnecessary_map_or`]: don't add parens if the parent expr comes from a macro fixes rust-lang/rust-clippy#14714

Fix let_unit_value suggests wrongly for format macros (rust-lang#15085

887b500

) Closes rust-lang/rust-clippy#15061 changelog: [`let_unit_value`] fix wrong suggestions for format macros

flip1995 and others added 12 commits August 6, 2025 16:02

Fix "comparision" typo in new lint template

a5af84c

Fix typo in lint issue template (rust-lang#15427)

faba846

Small typo I found while looking at recent lint requests/issues. changelog: none

Merge remote-tracking branch 'upstream/master' into rustup

f2b7e9f

Bump nightly version -> 2025-08-07

2893dc8

Bump Clippy version -> 0.1.91

d5f9f75

Rustup (rust-lang#15431)

334fb90

r? @ghost changelog: none

Merge commit '334fb906aef13d20050987b13448f37391bb97a2' into clippy-s…

d938543

…ubtree-update

Update Cargo.lock

770e6f1

rustbot assigned Manishearth Aug 7, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Aug 7, 2025

This comment was marked as off-topic.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025

blyxyas mentioned this pull request Aug 7, 2025

Do not notify if only rustbot is pinged in a commit message rust-lang/triagebot#2137

Open

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2025

bors merged commit 2fd855f into rust-lang:master Aug 7, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 7, 2025

bors mentioned this pull request Aug 7, 2025

Make mac calls include their semicolons #144714

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update #145056

Clippy subtree update #145056

Uh oh!

flip1995 commented Aug 7, 2025

Uh oh!

rustbot commented Aug 7, 2025

Uh oh!

This comment was marked as off-topic.

Manishearth commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

rust-timer commented Aug 7, 2025

Uh oh!

Uh oh!

Clippy subtree update #145056

Clippy subtree update #145056

Uh oh!

Conversation

flip1995 commented Aug 7, 2025

Uh oh!

rustbot commented Aug 7, 2025

Uh oh!

This comment was marked as off-topic.

Manishearth commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Aug 7, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!