Skip to content

Allow cross-compiling the Cranelift dist component #145320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 12, 2025

@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 12, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Aug 12, 2025

r? @jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned albertlarsan68 Aug 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

Copy link
Member

@shepmaster shepmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me (as a bootstrap rookie), but more importantly using this patch locally appears to allow me to cross-compile the dist artifacts.

@shepmaster
Copy link
Member

It is surprising that rustfmt didn't complain about missing commas on the new fields though.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 12, 2025

I think it's because it's in a macro.

@shepmaster shepmaster added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 12, 2025
@shepmaster
Copy link
Member

Preemptively beta-nominating this as #145252 is also for beta.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 12, 2025

@bors r=shepmaster rollup

@bors
Copy link
Collaborator

bors commented Aug 12, 2025

📌 Commit 614364c has been approved by shepmaster

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
bors added a commit that referenced this pull request Aug 13, 2025
Rollup of 11 pull requests

Successful merges:

 - #143467 (Add ASCII-related methods from `u8` and `MIN`/`MAX` to `core::ascii::Char`)
 - #144519 (Constify `SystemTime` methods)
 - #144642 (editorconfig: don't trim trailing whitespace in tests)
 - #144870 (Stabilize `path_file_prefix` feature)
 - #145269 (Deprecate RUST_TEST_* env variables)
 - #145274 (Remove unused `#[must_use]`)
 - #145289 (chore(ci): upgrade checkout to v5)
 - #145303 (Docs: Link to payload_as_str() from payload().)
 - #145308 (Adjust documentation of `dangling`)
 - #145320 (Allow cross-compiling the Cranelift dist component)
 - #145325 (Add `cast_init` and `cast_uninit` methods for pointers)

r? `@ghost`
`@rustbot` modify labels: rollup
@bjorn3
Copy link
Member

bjorn3 commented Aug 13, 2025

Preemptively beta-nominating this as #145252 is also for beta.

cg_clif shouldn't be built for beta at all.

@bors bors merged commit c4e82ab into rust-lang:master Aug 13, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 13, 2025
rust-timer added a commit that referenced this pull request Aug 13, 2025
Rollup merge of #145320 - Kobzol:fix-cranelift-codegen-dist, r=shepmaster

Allow cross-compiling the Cranelift dist component

Should help unblock #145252 (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/macos-13.20shutting.20down/with/534032174).
@Kobzol Kobzol deleted the fix-cranelift-codegen-dist branch August 13, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants