Skip to content

compiletest: assert that debugger provided for debuginfo tests and any tests actually collected for run #145326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

compiletest: assert that debugger provided for debuginfo tests and any tests actually collected for run #145326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tools/compiletest/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,11 @@ pub fn run_tests(config: Arc<Config>) {
}
}
}
// FIXME: not really true, few tests in tests/debuginfo do not require any debugger
assert!(
!configs.is_empty(),
"no debuggers found, debuginfo tests can't run without debugger"
);
} else {
configs.push(config.clone());
};
Expand All @@ -597,7 +602,7 @@ pub fn run_tests(config: Arc<Config>) {
for c in configs {
tests.extend(collect_and_make_tests(c));
}

assert!(!tests.is_empty(), "no test found for run, verify configuration");
tests.sort_by(|a, b| Ord::cmp(&a.desc.name, &b.desc.name));

// Delegate to the executor to filter and run the big list of test structures
Expand Down
Loading