Skip to content

actually provide the correct args to coroutine witnesses #145338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 13, 2025

#145194 accidentally provided all arguments of the closure to the witness, but the witness only takes the generic parameters of the defining scope:

let interior = Ty::new_coroutine_witness(tcx, expr_def_id.to_def_id(), parent_args);

Fixes #145288

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 13, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Aug 13, 2025

r? compiler-errors

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

compiler-errors is not on the review rotation at the moment.
They may take a while to respond.

@lcnr lcnr force-pushed the coroutine-witness-yikes branch from abde86f to 4d84149 Compare August 13, 2025 12:10
@compiler-errors
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 13, 2025

📌 Commit 4d84149 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlx-postgres Fails to Build on Latest 1.91.0
6 participants