Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #145349 and related to #141658.

cc @lolbinarycat

r? @fmease

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

fmease is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this differ from tests/rustdoc-js/sort-stability.rs added by binarycat except being smaller?

@fmease
Copy link
Member

fmease commented Aug 14, 2025

I'm slowly leaning towards a revert of the original PR similar to Zalathar esp. since we still have no minimal reproducer yet, however we might as well try one more time.

@GuillaumeGomez
Copy link
Member Author

The test is indeed the same. Strange it didn't trigger the original code. Gonna revert the original PR then.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2025
@GuillaumeGomez GuillaumeGomez deleted the unstable-search branch August 14, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-search Area: Rustdoc's search feature T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants