Skip to content

Conversation

compiler-errors
Copy link
Member

Fixes #145185.

Backporting this to stable and beta in favor of #145262 (comment).

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@compiler-errors compiler-errors added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 14, 2025
@traviscross traviscross added the I-lang-radar Items that are on lang's radar and will need eventual work or consideration. label Aug 15, 2025
@lcnr lcnr changed the title Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" [BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param" Aug 15, 2025
@lcnr
Copy link
Contributor

lcnr commented Aug 15, 2025

r=me

@lcnr
Copy link
Contributor

lcnr commented Aug 15, 2025

@bors
Copy link
Collaborator

bors commented Aug 15, 2025

📌 Commit b0ec0ec has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2025
@compiler-errors
Copy link
Member Author

@bors rollup=never

@fmease
Copy link
Member

fmease commented Aug 16, 2025

@bors p=10

as per https://forge.rust-lang.org/compiler/reviews.html#priority (beta backport) and mostly because we currently have 10 rollup=never PRs in the queue.

bors added a commit that referenced this pull request Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param"

Fixes #145185.

Backporting this to stable and beta in favor of #145262 (comment).

r? lcnr
@bors
Copy link
Collaborator

bors commented Aug 16, 2025

⌛ Testing commit b0ec0ec with merge 540c884...

@bors
Copy link
Collaborator

bors commented Aug 16, 2025

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2025
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2025
@fmease
Copy link
Member

fmease commented Aug 16, 2025

spurious? submodule checkouts never terminated or had some other failure, can't see the full logs

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025
bors added a commit that referenced this pull request Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param"

Fixes #145185.

Backporting this to stable and beta in favor of #145262 (comment).

r? lcnr
@bors
Copy link
Collaborator

bors commented Aug 16, 2025

⌛ Testing commit b0ec0ec with merge 8110175...

@rust-log-analyzer
Copy link
Collaborator

The job dist-ohos-armv7 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Aug 16, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2025
@fmease
Copy link
Member

fmease commented Aug 16, 2025

Network o.O ... again! At least 3 PRs have failed due to network issues in the last <24 hours, might need to bring this to T-infra...

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025
bors added a commit that referenced this pull request Aug 16, 2025
[BETA] Revert "Use DeepRejectCtxt in assemble_inherent_candidates_from_param"

Fixes #145185.

Backporting this to stable and beta in favor of #145262 (comment).

r? lcnr
@bors
Copy link
Collaborator

bors commented Aug 16, 2025

⌛ Testing commit b0ec0ec with merge b64cfa5...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-netbsd failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Aug 16, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 16, 2025
@fmease
Copy link
Member

fmease commented Aug 16, 2025

Network failure (#t-infra > Non-stop network timeouts across auto-builds)

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025
@bors
Copy link
Collaborator

bors commented Aug 16, 2025

⌛ Testing commit b0ec0ec with merge 47b72a3...

@bors
Copy link
Collaborator

bors commented Aug 17, 2025

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 47b72a3 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2025
@bors bors merged commit 47b72a3 into rust-lang:beta Aug 17, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 17, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2025
@compiler-errors compiler-errors deleted the revert-method-pref branch August 25, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants