Add static glibc to the nix dev shell #145451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 1 commit into rust-lang:master from WaffleLapkin:norailoveyou

Aug 18, 2025

+1 −0

Member

WaffleLapkin commented Aug 15, 2025

This fixes tests/ui/process/nofile-limit.rs which fails to link on nixos for me without this change.


          add static glibc to the nix dev shell

1d00627

this fixes `tests/ui/process/nofile-limit.rs` which fails to link on
nixos for me without this change

WaffleLapkin added O-NixOS A-meta labels

rustbot assigned Mark-Simulacrum

Collaborator

rustbot commented Aug 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added the S-waiting-on-review label

Member Author

WaffleLapkin commented Aug 15, 2025

r? Noratrieb

rustbot assigned Noratrieb and unassigned Mark-Simulacrum

Collaborator

rustbot commented Aug 15, 2025

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

Member

Noratrieb commented Aug 16, 2025

Collaborator

bors commented Aug 16, 2025

📌 Commit 1d00627 has been approved by Noratrieb

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

55fd065

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar mentioned this pull request

Rollup of 11 pull requests #145488

Closed

bors added a commit that referenced this pull request


          Auto merge of #145488 - Zalathar:rollup-xx2b6w1, r=Zalathar

a387a0c

Rollup of 11 pull requests

Successful merges:

 - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request


          Auto merge of #145488 - Zalathar:rollup-xx2b6w1, r=Zalathar

9c7b793

Rollup of 11 pull requests

Successful merges:

 - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations)
 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

2320c0c

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar mentioned this pull request

Rollup of 10 pull requests #145517

Closed

bors added a commit that referenced this pull request


          Auto merge of #145517 - Zalathar:rollup-yalwww1, r=Zalathar

8cd7e46

Rollup of 10 pull requests

Successful merges:

 - #140794 (Add information about group a lint belongs to)
 - #144476 (rustdoc-search: search backend with partitioned suffix tree)
 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

b286f01

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar mentioned this pull request

Rollup of 9 pull requests #145519

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

6ff963b

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

ed2b7f2

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar mentioned this pull request

Rollup of 10 pull requests #145521

Closed

bors added a commit that referenced this pull request


          Auto merge of #145521 - Zalathar:rollup-d4mqeq0, r=Zalathar

c29e078

Rollup of 10 pull requests

Successful merges:

 - #144476 (rustdoc-search: search backend with partitioned suffix tree)
 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)
 - #145489 (library: Migrate from `cfg_if` to `cfg_select`)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request


          Auto merge of #145519 - Zalathar:rollup-28idalp, r=Zalathar

f12e663

Rollup of 9 pull requests

Successful merges:

 - #144476 (rustdoc-search: search backend with partitioned suffix tree)
 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

79e2adc

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

Zalathar mentioned this pull request

Rollup of 10 pull requests #145526

Closed

bors added a commit that referenced this pull request


          Auto merge of #145526 - Zalathar:rollup-4boj5q8, r=Zalathar

789878b

Rollup of 10 pull requests

Successful merges:

 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

acc0d0f

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

jhpratt mentioned this pull request

Manual rollup of 19 pull requests #145545

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request


          Rollup merge of rust-lang#145451 - WaffleLapkin:norailoveyou, r=Norat…

4f534b7

…rieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

jhpratt mentioned this pull request

Rollup of 19 pull requests #145546

Closed

bors added a commit that referenced this pull request


          Auto merge of #145526 - Zalathar:rollup-4boj5q8, r=Zalathar

ab964e1

Rollup of 10 pull requests

Successful merges:

 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

Zalathar mentioned this pull request

Rollup of 10 pull requests #145551

Merged

bors added a commit that referenced this pull request


          Auto merge of #145551 - Zalathar:rollup-eo75r94, r=Zalathar

e7ec3ca

Rollup of 10 pull requests

Successful merges:

 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit that referenced this pull request


          Auto merge of #145551 - Zalathar:rollup-eo75r94, r=Zalathar

239e8b1

Rollup of 10 pull requests

Successful merges:

 - #144838 (Fix outdated doc comment)
 - #145206 (Port `#[custom_mir(..)]` to the new attribute system)
 - #145208 (Implement declarative (`macro_rules!`) derive macros (RFC 3698))
 - #145309 (Fix `-Zregparm` for LLVM builtins)
 - #145355 (Add codegen test for issue 122734)
 - #145420 (cg_llvm: Use LLVM-C bindings for `LLVMSetTailCallKind`, `LLVMGetTypeKind`)
 - #145451 (Add static glibc to the nix dev shell)
 - #145460 (Speedup `copy_src_dirs` in bootstrap)
 - #145476 (Fix typo in doc for library/std/src/fs.rs#set_permissions)
 - #145485 (Fix deprecation attributes on foreign statics)

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit 3b396fc into rust-lang:master

10 checks passed

rustbot added this to the 1.91.0 milestone

rust-timer added a commit that referenced this pull request


          Unrolled build for #145451

2fa99e9

Rollup merge of #145451 - WaffleLapkin:norailoveyou, r=Noratrieb

Add static glibc to the nix dev shell

This fixes `tests/ui/process/nofile-limit.rs` which fails to link on nixos for me without this change.

WaffleLapkin deleted the norailoveyou branch

August 18, 2025 18:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta O-NixOS S-waiting-on-bors