Skip to content

Conversation

cjgillot
Copy link
Contributor

r? @ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Aug 16, 2025
Only scan each definition once for dead-code.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025
@rust-bors
Copy link

rust-bors bot commented Aug 16, 2025

☀️ Try build successful (CI)
Build commit: c2706c3 (c2706c39a5d598b7500f28a70e66a252dc595075, parent: 2e2642e641a941f0a1400c7827fd89aa86fef8f4)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c2706c3): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
1.1% [0.9%, 1.4%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-4.7%, -0.2%] 12
Improvements ✅
(secondary)
-1.2% [-4.6%, -0.1%] 5
All ❌✅ (primary) -0.6% [-4.7%, 1.4%] 14

Max RSS (memory usage)

Results (primary 1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

Results (primary -4.4%, secondary 7.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
12.8% [5.6%, 15.9%] 4
Improvements ✅
(primary)
-4.4% [-4.4%, -4.4%] 1
Improvements ✅
(secondary)
-3.2% [-3.8%, -2.6%] 2
All ❌✅ (primary) -4.4% [-4.4%, -4.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.222s -> 470.642s (0.09%)
Artifact size: 377.51 MiB -> 377.49 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025
@cjgillot cjgillot marked this pull request as ready for review August 16, 2025 22:06
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2025
@cjgillot
Copy link
Contributor Author

r? compiler

@fee1-dead
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 18, 2025

📌 Commit 9cd0bf2 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025
@jhpratt
Copy link
Member

jhpratt commented Aug 23, 2025

putting this ahead of a rollup=iffy in case the rollup fails

@bors p=1

@bors
Copy link
Collaborator

bors commented Aug 23, 2025

⌛ Testing commit 9cd0bf2 with merge 5b6ceb5...

@bors
Copy link
Collaborator

bors commented Aug 23, 2025

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing 5b6ceb5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2025
@bors bors merged commit 5b6ceb5 into rust-lang:master Aug 23, 2025
12 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 23, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8df154b (parent) -> 5b6ceb5 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5b6ceb58f800079f8c59f5194b5db08924693927 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3936.6s -> 5865.6s (49.0%)
  2. pr-check-1: 1696.7s -> 1345.7s (-20.7%)
  3. aarch64-apple: 5641.0s -> 6714.1s (19.0%)
  4. x86_64-gnu-distcheck: 8621.1s -> 7502.0s (-13.0%)
  5. x86_64-gnu-tools: 3898.7s -> 3400.8s (-12.8%)
  6. aarch64-gnu-llvm-19-2: 2500.9s -> 2201.1s (-12.0%)
  7. dist-aarch64-apple: 6101.0s -> 6806.9s (11.6%)
  8. x86_64-gnu-llvm-20-1: 3678.5s -> 3265.4s (-11.2%)
  9. x86_64-gnu-miri: 5060.4s -> 4511.7s (-10.8%)
  10. aarch64-gnu-debug: 4751.2s -> 4242.1s (-10.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@cjgillot cjgillot deleted the live-or-dead-onescan branch August 23, 2025 11:47
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5b6ceb5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [1.9%, 4.8%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary 0.7%, secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.0%, 2.3%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-4.0% [-4.6%, -3.0%] 7
All ❌✅ (primary) 0.7% [-2.2%, 2.3%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.037s -> 468.26s (0.26%)
Artifact size: 378.11 MiB -> 378.14 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants