Stabilize char_max_len

[GrigorenkoPV]

Tracking issue: #121714

r? t-libs-api

@rustbot label +needs-fcp -T-libs +T-libs-api

Closes #121714

[Amanieu]

Nominating for libs-api discussion since I'm not sure we want to stabilize both the associated constants and the free constants in the char module.

[HTGAzureX1212]

Nominating for libs-api discussion since I'm not sure we want to stabilize both the associated constants and the free constants in the char module.

Would removing the freestanding constants be feasible? All constants in primitive type "modules" seem to be deprecated themselves anyway, we shouldn't add a constant just for it to be deprecated.

[joshtriplett]

The main reason to keep the freestanding constants is that we don't currently support importing associated constants. You would always have to reference them with the char:: prefix.

[Amanieu]

Given that we've deprecated a lot of the non-associated constants, I think we should only be stabilizing the associated constants.

@rfcbot merge

[rfcbot]

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se
• @the8472

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[bors]

☔ The latest upstream changes (presumably #145916) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.