[draft] multiple single-line suggestions on malformed function calls when possible #145630
+188
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
scrabsha
changed the title
scrabsha
force-pushed
the
push-mklqnnqsoqky
branch
2 times, most recently
from
4c34626 to
d368e3f
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-mklqnnqsoqky
branch
from
d368e3f to
fdc297f
Compare
scrabsha
force-pushed
the
push-mklqnnqsoqky
branch
from
fdc297f to
bd4b755
Compare
scrabsha
commented
Aug 19, 2025
Comment on lines
+25
to
+26
| LL | f(/* _ */, /* _ */f); | ||
| | ++++++++++++++++ |
There was a problem hiding this comment.
This is weird >.< I must investigate this
|
Discussed with @jdonszelmann off-github: it'd be better to try to split this huge function in several smaller functions with clearer names first. I'll try to do that in a separate commit, and will open a separate PR if it gets too big. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement what is described in #144966 (comment).
Feedback is welcome, but the code is utterly buggy and far from ready.