Skip to content

Enforce in bootstrap that test must have stage at least 1 (except for compiletest) #145663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Enforce in bootstrap that test must have stage at least 1 (except for compiletest) #145663

wants to merge 23 commits into from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 20, 2025 •
edited
Loading

This PR cleans up a bunch of test steps and adds metadata to them. I didn't yet touch the most complicated step (CompileTest), I'm leaving that for another PR.

Testing anything on stage 0 is only possible for compiletest and with build.allow-compiletest-stage0. Testing anything else on stage 0 will either produce a nice error or crash with a stage being subtracted below zero.

r? @jieyouxu

try-job: dist-x86_64-linux
try-job: aarch64-gnu
try-job: arm-android
try-job: x86_64-gnu-llvm-20*
try-job: x86_64-msvc-*
try-job: aarch64-apple
try-job: test-various

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 20, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Aug 20, 2025
@rust-bors
Auto merge of #145663 - Kobzol:bootstrap-test, r=<try>
73b618d 
Enforce in bootstrap that test must have stage at least 1 (except for compiletest)

try-job: dist-x86_64-linux
try-job: aarch64-gnu
try-job: arm-android
try-job: `x86_64-gnu-llvm-20*`
try-job: `x86_64-msvc-*`
try-job: aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-CI Area: Our Github Actions CI T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member Author

Kobzol commented Aug 20, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 20, 2025
@rust-bors
Auto merge of #145663 - Kobzol:bootstrap-test, r=<try>
06dca67 
Enforce in bootstrap that test must have stage at least 1 (except for compiletest)

try-job: dist-x86_64-linux
try-job: aarch64-gnu
try-job: arm-android
try-job: `x86_64-gnu-llvm-20*`
try-job: `x86_64-msvc-*`
try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Aug 20, 2025

💔 Test for 06dca67 failed: CI. Failed jobs:

@Kobzol
Copy link
Member Author

Kobzol commented Aug 20, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 20, 2025
@rust-bors
Auto merge of #145663 - Kobzol:bootstrap-test, r=<try>
71ba459 
Enforce in bootstrap that test must have stage at least 1 (except for compiletest)

try-job: dist-x86_64-linux
try-job: aarch64-gnu
try-job: arm-android
try-job: `x86_64-gnu-llvm-20*`
try-job: `x86_64-msvc-*`
try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Aug 20, 2025

💔 Test for 71ba459 failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Kobzol added 21 commits August 27, 2025 11:40
@Kobzol
Forbid running tests on stage 0 unless `build.compiletest-allow-stage…
fbaed59 
…0` is enabled
@Kobzol
Add snapshot test for x test
43f1f63
@Kobzol
Fix staging of TestFloatParse
09a7ed6 
The tool wasn't useful for anything, it was only built as a part of the test, but we can just use `cargo test` and `cargo run` in the test, no need to (pre-)build the tool itself.
@Kobzol
Remove compiler_for from test::CodegenGCC
4181ae8
@Kobzol
Remove compiler_for from test::CodegenCranelift
1f81491
@Kobzol
Refactor test::LintDocs
2f1bbc6
@Kobzol
Remove stage0 checking
df99001
@Kobzol
Small refactoring around RemoteCopyLibs
92e9d25
@Kobzol
Add metadata to a bunch of steps, rename variables and add comments
b977586
@Kobzol
Move the test! macro closer to its usages
0a27573
@Kobzol
Fix staging for compiler/std crate tests
d598209
@Kobzol
Fix spacing when testing individual crates
85274eb
@Kobzol
Do not run tests on CI in stage 0
4728ef4
@Kobzol
Add change tracker entry
d1e94e1
@Kobzol
Skip bootstrap tests on CI
6c93dfb
@Kobzol
Fix doclink
a9b85e9
@Kobzol
Fake nodejs in snapshot test
4da586f
@Kobzol
Fix tests and doclink
c8ae70a
@Kobzol
Add test stage 2 snapshot tests
ee109d3
@Kobzol
Fix stage 1 compiler tests
a000297
@Kobzol
Do not run lint-docs tests in stage 1 x test by default
9a75636
@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 27, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 27, 2025
@rust-bors
Auto merge of #145663 - Kobzol:bootstrap-test, r=<try>
d47e319 
Enforce in bootstrap that test must have stage at least 1 (except for compiletest)

try-job: dist-x86_64-linux
try-job: aarch64-gnu
try-job: arm-android
try-job: `x86_64-gnu-llvm-20*`
try-job: `x86_64-msvc-*`
try-job: aarch64-apple
try-job: test-various
@Kobzol
Copy link
Member Author

Kobzol commented Aug 27, 2025

Ok, should be ready for a review now.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2025
@rust-bors
Copy link

rust-bors bot commented Aug 27, 2025

☀️ Try build successful (CI)
Build commit: d47e319 (d47e319edabed56167a4e98e0b0e18f8f415a7ff, parent: 4f808ba6bf9f1c8dde30d009e73386d984491587)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @rustbot @rust-log-analyzer @bors @jieyouxu