Skip to content

add a flag to codegen fn attrs for foreign items #145855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add a flag to codegen fn attrs for foreign items #145855

wants to merge 1 commit into from
+16 −14

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Aug 25, 2025 •
edited
Loading

r? @ghost

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@jdonszelmann jdonszelmann mentioned this pull request Aug 25, 2025
Merged
@jdonszelmann
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 25, 2025
@rust-bors
Auto merge of #145855 - jdonszelmann:codegen-fn-attrs-foreign-item, r…
007dfa5 
…=<try>

add a flag to codegen fn attrs for foreign items
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

@bors try cancel

@rust-bors
Copy link

rust-bors bot commented Aug 25, 2025

Try build cancelled. Cancelled workflows:

@jdonszelmann jdonszelmann force-pushed the codegen-fn-attrs-foreign-item branch from 95e3672 to 5473fb4 Compare August 25, 2025 17:12
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@jdonszelmann
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 25, 2025
@rust-bors
Auto merge of #145855 - jdonszelmann:codegen-fn-attrs-foreign-item, r…
e115067 
…=<try>

add a flag to codegen fn attrs for foreign items
bjorn3
bjorn3 reviewed Aug 25, 2025
View reviewed changes
@rust-bors
Copy link

rust-bors bot commented Aug 25, 2025

☀️ Try build successful (CI)
Build commit: e115067 (e115067424950f234cd5e5d3eef9c9b39d627e61, parent: b779120cad2c93e53c0dfb7007c1214b2b275183)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e115067): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.5%, -0.3%] 6
Improvements ✅
(secondary)		 -0.4% [-0.7%, -0.2%] 3
All ❌✅ (primary) -0.4% [-0.5%, -0.3%] 6

Max RSS (memory usage)

Results (primary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.0%] 8
Regressions ❌
(secondary)		 0.7% [0.7%, 0.7%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 8

Bootstrap: 467.387s -> 468.157s (0.16%)
Artifact size: 378.40 MiB -> 378.37 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 26, 2025
@jdonszelmann
Copy link
Contributor Author

Well, that seems to have mostly gone and done it. Neat!

@jdonszelmann jdonszelmann force-pushed the codegen-fn-attrs-foreign-item branch from 5473fb4 to c46561e Compare August 26, 2025 07:01
@jdonszelmann
Copy link
Contributor Author

r? @bjorn3 alrighty, I think this resolves the standing issues. lovely!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
bjorn3
bjorn3 reviewed Aug 26, 2025
View reviewed changes
src/tools/miri/src/helpers.rs Outdated
Some(adt.did()) == self.ecx.tcx.lang_items().unsafe_cell_type(),
ty::Adt(adt, _) => {
Some(adt.did()) == self.ecx.tcx.lang_items().unsafe_cell_type()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below please revert the reformatting. Miri has different formatting rules.

bjorn3
bjorn3 approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@bjorn3 bjorn3 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with miri formatting changes reverted

View changes since this review

@jdonszelmann jdonszelmann force-pushed the codegen-fn-attrs-foreign-item branch from c46561e to d66ca53 Compare August 26, 2025 11:05
@bjorn3
Copy link
Member

bjorn3 commented Aug 26, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit d66ca53 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145855 - jdonszelmann:codegen-fn-attrs-foreign-item, r…
dee2538 
…=bjorn3

add a flag to codegen fn attrs for foreign items

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Aug 26, 2025

⌛ Testing commit d66ca53 with merge dee2538...

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
checking C++ file formatting
spellcheck files
building external tool typos from package [email protected]
finished building tool typos
npm ERR! code E429
npm ERR! 429 Too Many Requests - GET https://registry.npmjs.org/zod/-/zod-3.23.8.tgz

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-08-26T11_46_24_284Z-debug-0.log
tidy error: IO error: npm install returned exit code exit status: 1
npm install did not exit successfully
some tidy checks failed
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1583:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1225:29

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Build completed unsuccessfully in 0:18:10
  local time: Tue Aug 26 12:01:55 UTC 2025
  network time: Tue, 26 Aug 2025 12:01:55 GMT
##[error]Process completed with exit code 1.

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2025
@jieyouxu
Copy link
Member

@bors retry (tidy)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025
@bjorn3
Copy link
Member

bjorn3 commented Aug 26, 2025

@bors retry spurious npm rate limit

@jdonszelmann jdonszelmann mentioned this pull request Aug 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

@bjorn3 bjorn3

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdonszelmann @rustbot @rust-timer @rust-log-analyzer @bjorn3 @bors @jieyouxu