Introduce RUSTUP_CONCURRENT_DOWNLOADS to control concurrency
#4450
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranciscoTGouveia
force-pushed
the
control-concurrent-downloads
branch
from
e437bb8 to
d5c884e
Compare
djc
approved these changes
Aug 20, 2025
FranciscoTGouveia
force-pushed
the
control-concurrent-downloads
branch
from
153405c to
bd87c3a
Compare
|
During a conversation about this PR, it was noted that enabling concurrent downloads by default may introduce a slight performance regression for some users. With that said, would it be preferable to revert the default behavior of max-concurrency (defined in #4436) and leave it up to the user to opt in to concurrency, or should we keep it and address this, if necessary, in a separate issue or PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (based on this comment) introduces a new environment variable,
RUSTUP_CONCURRENT_DOWNLOADS.This allows users to configure how many components are downloaded concurrently -- or, in the case of
rustup check, how many toolchains are checked concurrently.