Skip to content

Commit

Permalink
Update comment about sending EndOfPublish (MystenLabs#15361)
Browse files Browse the repository at this point in the history
## Description 

Describe the changes or additions included in this PR.

## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
  • Loading branch information
halfprice authored Dec 14, 2023
1 parent 96bcaf4 commit 73bd01e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/sui-core/src/consensus_adapter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,8 @@ impl ConsensusAdapter {
// Note that there could be a race condition here where we enter this check in RejectAllCerts state.
// In that case we don't need to send EndOfPublish because condition to enter
// RejectAllCerts is when 2f+1 other validators already sequenced their EndOfPublish message.
// Also note that we could sent multiple EndOfPublish due to that multiple tasks can enter here with
// pending_count == 0. This doesn't affect correctness.
if epoch_store
.get_reconfig_state_read_lock_guard()
.is_reject_user_certs()
Expand Down

0 comments on commit 73bd01e

Please sign in to comment.