do not adjust default settings on initialization #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, newly initialized fan devices (via `imanager_hwmon_probe`) would be configured for "automatic speed control". This may override any existing or default configuration states for these fans (ie. default/ custom states defined via a BIOS configuration). The following removes the driver's force to automatic-speed-control state on initialization and just interprets the current configuration states for existing fans. Signed-off-by: James Knight <[email protected]>
|
I agree. Thanks James for submitting this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following prevents the imanager_hwmon module from configuring "automatic speed control" for probed fan devices. For some uses cases, there is a desire to use existing/default fan control settings populated from a BIOS (or another driver, previously loaded driver instance, etc.).
However, this change removes a possible assumption that a newly loaded hwmon module will automatically configure detected fans into automatic mode. Systems which do not have automatic fan control by default would need to configured their fans to automatic mode after loading the driver. If this is a common/dominate use case, an alternative approach would be having a configuration option to prevent automatic fan control for some systems.