Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing emails #430

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Marketing emails #430

wants to merge 36 commits into from

Conversation

00salmon
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copy link
Contributor

@noahwc noahwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple buts of cleanup but looks good!

@@ -1,7 +1,7 @@
{
"name": "@saasquatch/mint-components",
"title": "Mint Components",
"version": "1.11.0",
"version": "1.12.1-15",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a real version pre-launch

Comment on lines +3 to +9
// import scenario from "./sqm-marketing-emails-checkbox.feature";

export default {
title: "Components/Change Marketing Emails Status",
// parameters: {
// scenario,
// },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just remove?

@@ -88,7 +88,7 @@ export function usePortalRegistrationForm(props: PortalRegistrationForm) {

const submit = async (event: any) => {
let formControls = event.target.getFormControls();

console.log("Test 123");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove

@@ -139,10 +139,12 @@ export function usePortalRegistrationForm(props: PortalRegistrationForm) {
validationErrors: {},
});
const { email, password } = formData;
console.log("form data is ", formData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should remove

Copy link
Contributor

@Locrian24 Locrian24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 . Just needs pre-release bumps and merge in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants