-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketing emails #430
base: master
Are you sure you want to change the base?
Marketing emails #430
Conversation
...omponents/src/components/sqm-marketing-emails-checkbox/sqm-marketing-emails-checkbox.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple buts of cleanup but looks good!
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "@saasquatch/mint-components", | |||
"title": "Mint Components", | |||
"version": "1.11.0", | |||
"version": "1.12.1-15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a real version pre-launch
// import scenario from "./sqm-marketing-emails-checkbox.feature"; | ||
|
||
export default { | ||
title: "Components/Change Marketing Emails Status", | ||
// parameters: { | ||
// scenario, | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just remove?
@@ -88,7 +88,7 @@ export function usePortalRegistrationForm(props: PortalRegistrationForm) { | |||
|
|||
const submit = async (event: any) => { | |||
let formControls = event.target.getFormControls(); | |||
|
|||
console.log("Test 123"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove
@@ -139,10 +139,12 @@ export function usePortalRegistrationForm(props: PortalRegistrationForm) { | |||
validationErrors: {}, | |||
}); | |||
const { email, password } = formData; | |||
console.log("form data is ", formData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 . Just needs pre-release bumps and merge in master
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review