Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsite google registration #431

Merged
merged 72 commits into from
Mar 19, 2025
Merged

Microsite google registration #431

merged 72 commits into from
Mar 19, 2025

Conversation

AndiLuo
Copy link
Contributor

@AndiLuo AndiLuo commented Mar 3, 2025 •
edited by Locrian24
Loading

Description of the change

Microsite google login implementation

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

AndiLuo and others added 29 commits February 20, 2025 11:42
@AndiLuo
Mocking google login screens WIP
216ad04
@AndiLuo
Added new components for google login
7efb579
@AndiLuo
Add state to stories
5d41275
@Locrian24
google sign in button
62c3f35
@Locrian24
Merge branch 'microsite-google-registration' of github.com:saasquatch…
ba64db5 
…/program-tools into microsite-google-registration
@AndiLuo
Created slot for conditionally rendering google and regular fields
6201777
@AndiLuo
Added stories
26a61e6
@AndiLuo
Remove RegsitrationFieldsView conditional rendering
e460abc
@AndiLuo
Wired up some functionality for form switching in sqm-portal-registra…
7bc7353 
…tion
@Locrian24
basic hooks for new flow and google sign in button
c1f4772
@AndiLuo
Updated Base Registration styles
7abf695
@AndiLuo
Merge branch 'microsite-google-registration' of https://github.com/sa…
0bf5241 
…asquatch/program-tools into microsite-google-registration
@AndiLuo
Renamed registration forms and updated var names
4c3661e
@AndiLuo
Fix import errors
70a5799
@Locrian24
fix imports for now
2067afb
@AndiLuo
Cleanup imports
3ee49da
@AndiLuo
:wq!
6ff55ef 
Merge branch 'microsite-google-registration' of https://github.com/saasquatch/program-tools into microsite-google-registration
@AndiLuo
Fix styling and story
da334a9
@Locrian24
reuse main registration form code for google sign in flow
4c52967
@Locrian24
Merge branch 'microsite-google-registration' of github.com:saasquatch…
f849ea4 
…/program-tools into microsite-google-registration
@AndiLuo
Add state to sqm-portal-login and update view + stories
decbbeb
@Locrian24
allow demo data for new hook
7935ac5
@Locrian24
Merge branch 'microsite-google-registration' of github.com:saasquatch…
df6fea4 
…/program-tools into microsite-google-registration
@Locrian24
add prop to portal login
cf6793b
@AndiLuo
Added specs and cleanup
18a490f
@AndiLuo
Modify stories
315feba
@AndiLuo
Added redirect-to-login button for base regisration form and hid it i…
5376855 
…n google-registration form.
@Locrian24
add showGoogleLogin to login component
6ceaec5
@Locrian24
Merge branch 'microsite-google-registration' of github.com:saasquatch…
c2bacd5 
…/program-tools into microsite-google-registration
@AndiLuo AndiLuo requested a review from 00salmon March 3, 2025 19:23
noahwc
noahwc reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@noahwc noahwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple few bits of housekeeping

@00salmon
Copy link
Contributor

should fix these merge conflicts as well 🙏

00salmon
00salmon reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@00salmon 00salmon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an empty file left behind that needs cleaning up:
packages/mint-components/src/components/sqm-portal-google-login/usePortalGoogleLogin.tsx

00salmon
00salmon previously approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@00salmon 00salmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AndiLuo AndiLuo requested a review from 00salmon March 18, 2025 22:00
@Locrian24 Locrian24 merged commit 72d2e0a into master Mar 19, 2025
8 of 11 checks passed
@Locrian24 Locrian24 deleted the microsite-google-registration branch March 19, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahwc noahwc noahwc left review comments

@00salmon 00salmon 00salmon approved these changes

@Ultha258 Ultha258 Ultha258 left review comments

@Locrian24 Locrian24 Awaiting requested review from Locrian24

@zachharrison zachharrison Awaiting requested review from zachharrison

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndiLuo @00salmon @noahwc @Locrian24 @Ultha258 @zachharrison