Skip to content

Commit

Permalink
Merge branch 'release/1.6.1'
Browse files Browse the repository at this point in the history
  • Loading branch information
jdewind committed Jul 30, 2015
2 parents 66e6cd4 + 0a8f6ef commit 63269dc
Show file tree
Hide file tree
Showing 18 changed files with 54 additions and 36 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
language: objective-c
script: rake specs:all

osx_image: xcode6.4
install:
- bundle install
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,11 @@ Nothing in this version has changed that would cause those that are upgrading fr
**[Changes](#changes)**

1. Ad-Hoc initializers can be used via the JSObjectionInjector and JSObjectFactory

# 1.6.1

**[Changes](#changes)**

1. Fixed build issues in XCode 6.4 and updated Nimble & Quick testing libraries
2. Improved test output via xcpretty
3. Fixed regression raised in issue #94 (https://github.com/atomicobject/objection/issues/94)
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
source "http://rubygems.org"
gem "xcpretty"
10 changes: 10 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
GEM
remote: http://rubygems.org/
specs:
xcpretty (0.1.10)

PLATFORMS
ruby

DEPENDENCIES
xcpretty
4 changes: 2 additions & 2 deletions Objection-Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.6</string>
<string>1.6.1</string>
<key>CFBundleSignature</key>
<string>ATOM</string>
<key>CFBundleVersion</key>
<string>1.6</string>
<string>1.6.1</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion Objection.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'Objection'
s.version = '1.6'
s.version = '1.6.1'
s.summary = 'A lightweight dependency injection framework for Objective-C.'
s.author = { 'Justin DeWind' => '[email protected]' }
s.source = { :git => 'https://github.com/atomicobject/objection.git', :tag => "#{s.version}" }
Expand Down
18 changes: 3 additions & 15 deletions Objection.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@
0867D690FE84028FC02AAC07 /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 0610;
LastUpgradeCheck = 0640;
};
buildConfigurationList = 1DEB922208733DC00010E9CD /* Build configuration list for PBXProject "Objection" */;
compatibilityVersion = "Xcode 3.2";
Expand Down Expand Up @@ -1016,10 +1016,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = (
"$(ARCHS_STANDARD)",
armv7s,
);
CLANG_ENABLE_OBJC_ARC = YES;
COPY_PHASE_STRIP = NO;
DSTROOT = /tmp/Objection.dst;
Expand All @@ -1045,10 +1041,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = (
"$(ARCHS_STANDARD)",
armv7s,
);
CLANG_ENABLE_OBJC_ARC = YES;
DSTROOT = /tmp/Objection.dst;
FRAMEWORK_SEARCH_PATHS = (
Expand Down Expand Up @@ -1079,6 +1071,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = c99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_OPTIMIZATION_LEVEL = 0;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Expand All @@ -1105,6 +1098,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = c99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
Expand All @@ -1120,7 +1114,6 @@
4B25BE4B1291C43400821DC1 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
COPY_PHASE_STRIP = NO;
GCC_DYNAMIC_NO_PIC = NO;
GCC_OPTIMIZATION_LEVEL = 0;
Expand All @@ -1134,7 +1127,6 @@
4B25BE4C1291C43400821DC1 /* Release */ = {
isa = XCBuildConfiguration;
buildSettings = {
ARCHS = "$(ARCHS_STANDARD_INCLUDING_64_BIT)";
COPY_PHASE_STRIP = YES;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
GCC_C_LANGUAGE_STANDARD = c99;
Expand All @@ -1151,7 +1143,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD)";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
EMBEDDED_CONTENT_CONTAINS_SWIFT = YES;
Expand Down Expand Up @@ -1195,7 +1186,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD)";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
EMBEDDED_CONTENT_CONTAINS_SWIFT = YES;
Expand Down Expand Up @@ -1235,7 +1225,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
Expand Down Expand Up @@ -1274,7 +1263,6 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
COMBINE_HIDPI_IMAGES = YES;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0610"
LastUpgradeVersion = "0640"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0610"
LastUpgradeVersion = "0640"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0610"
LastUpgradeVersion = "0640"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0610"
LastUpgradeVersion = "0640"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0610"
LastUpgradeVersion = "0640"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,9 @@ objection_initializer(truckWithMake:model:)
@end

- (void)buildCar {
ConfigurableCar *car = [self.objectFactory getObject:[ConfigurableCar class], initializer: @selector(initWithModel:) withArgumentList:@[@"VW", @"Passat"]];
ConfigurableCar *car = [self.objectFactory getObject:[ConfigurableCar class],
initializer: @selector(initWithModel:)
withArgumentList:@[@"Passat"]];
}
```
Expand Down Expand Up @@ -406,7 +408,7 @@ It can be downloaded [here](http://objection-framework.org/files/Objection-1.5.t
Edit your Pofile
edit Podfile
pod 'Objection', '1.6'
pod 'Objection', '1.6.1'
Now you can install Objection
Expand Down
17 changes: 11 additions & 6 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ end
namespace :artifact do
desc "Build OSX Framework"
task :osx => :clean do
system_or_exit(%Q[#{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -target Objection -configuration Release build], nil)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -target Objection -configuration Release build | xcpretty -c], nil)
end

desc "Build iOS Framework"
task :ios => :clean do
system_or_exit(%Q[#{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -target Objection-iOS -configuration Release build] , nil)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -target Objection-iOS -configuration Release build | xcpretty -c] , nil)
end

require 'rake/clean'
Expand All @@ -56,28 +56,33 @@ end

task :clean do
stdout = File.join(ENV['CC_BUILD_ARTIFACTS'], "clean.output") if (ENV['IS_CI_BOX'])
system_or_exit(%Q[#{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -alltargets -configuration #{CONFIGURATION} clean], stdout)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -alltargets -configuration #{CONFIGURATION} clean | xcpretty -c], stdout)
end

task :build_all do
stdout = File.join(ENV['CC_BUILD_ARTIFACTS'], "build_all.output") if (ENV['IS_CI_BOX'])
system_or_exit(%Q[#{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -alltargets -configuration #{CONFIGURATION} build], stdout)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -alltargets -configuration #{CONFIGURATION} build | xcpretty -c], stdout)
end

task :publish do
system_or_exit %Q[pod trunk publish Objection.podspec --allow-warnings]
end


namespace :specs do
desc "All Specs"
task :all => [:osx, :ios]

desc "OS X Specs"
task :osx do
stdout = File.join(ENV['CC_BUILD_ARTIFACTS'], "build_specs.output") if (ENV['IS_CI_BOX'])
system_or_exit(%Q[#{xcodebuild_executable} test -project #{PROJECT_NAME}.xcodeproj -scheme #{SPECS_TARGET_NAME} -configuration #{CONFIGURATION}], stdout)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} test -project #{PROJECT_NAME}.xcodeproj -scheme #{SPECS_TARGET_NAME} -configuration #{CONFIGURATION} | xcpretty -c], stdout)
end

desc "iOS Specs"
task :ios do
stdout = File.join(ENV['CC_BUILD_ARTIFACTS'], "build_uispecs.output") if (ENV['IS_CI_BOX'])
ENV["TEST_AFTER_BUILD"] = "Yes"
system_or_exit(%Q[#{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -scheme #{UI_SPECS_TARGET_NAME} -sdk iphonesimulator -configuration #{CONFIGURATION} -destination 'platform=iOS Simulator,name=iPhone 6,OS=latest' test ], stdout)
system_or_exit(%Q[set -o pipefail; #{xcodebuild_executable} -project #{PROJECT_NAME}.xcodeproj -scheme #{UI_SPECS_TARGET_NAME} -sdk iphonesimulator -configuration #{CONFIGURATION} -destination 'platform=iOS Simulator,name=iPhone 6,OS=latest' test | xcpretty -c], stdout)
end
end
1 change: 1 addition & 0 deletions Source/JSObjectionProviderEntry.m
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ @interface JSObjectionProviderEntry () {
@end

@implementation JSObjectionProviderEntry
@synthesize lifeCycle = _lifeCycle;

- (id)initWithProvider:(id<JSObjectionProvider>)theProvider lifeCycle:(JSObjectionScope)theLifeCycle {
if ((self = [super init])) {
Expand Down
4 changes: 2 additions & 2 deletions Specs/BasicUsageSpecs.m
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
[[JSObjection defaultInjector] injectDependencies:car];

assertThatBool([car awake], isTrue());
assertThatBool([car.engine awake], isFalse());
assertThatBool([car.engine awake], isTrue());
});

it(@"defaults to returning a new instance", ^{
Expand Down Expand Up @@ -112,7 +112,7 @@
id car = [[JSObjection defaultInjector] getObject:[Car class]];

assertThatBool([engine awake], isTrue());
assertThatBool([car awake], isFalse());
assertThatBool([car awake], isTrue());
});


Expand Down
2 changes: 1 addition & 1 deletion Vendor/Nimble
Submodule Nimble updated 65 files
+1 −0 .gitignore
+0 −9 .travis.yml
+23 −4 CONTRIBUTING.md
+2 −2 Nimble.podspec
+52 −40 Nimble.xcodeproj/project.pbxproj
+2 −2 Nimble.xcodeproj/project.xcworkspace/xcshareddata/Nimble.xccheckout
+2 −3 Nimble/Adapters/AdapterProtocols.swift
+20 −0 Nimble/Adapters/AssertionDispatcher.swift
+54 −6 Nimble/Adapters/AssertionRecorder.swift
+28 −0 Nimble/Adapters/NimbleXCTestHandler.swift
+0 −10 Nimble/Adapters/XCTestHandler.swift
+8 −8 Nimble/DSL+Wait.swift
+8 −6 Nimble/DSL.swift
+31 −18 Nimble/Expectation.swift
+51 −4 Nimble/Expression.swift
+32 −7 Nimble/FailureMessage.swift
+88 −0 Nimble/Matchers/AllPass.swift
+11 −1 Nimble/Matchers/BeAKindOf.swift
+11 −1 Nimble/Matchers/BeAnInstanceOf.swift
+3 −3 Nimble/Matchers/BeCloseTo.swift
+2 −1 Nimble/Matchers/BeEmpty.swift
+2 −2 Nimble/Matchers/BeGreaterThan.swift
+2 −2 Nimble/Matchers/BeGreaterThanOrEqualTo.swift
+1 −1 Nimble/Matchers/BeIdenticalTo.swift
+2 −2 Nimble/Matchers/BeLessThan.swift
+1 −1 Nimble/Matchers/BeLessThanOrEqual.swift
+38 −21 Nimble/Matchers/BeLogical.swift
+1 −1 Nimble/Matchers/BeNil.swift
+2 −2 Nimble/Matchers/BeginWith.swift
+16 −2 Nimble/Matchers/Contain.swift
+5 −4 Nimble/Matchers/EndWith.swift
+63 −1 Nimble/Matchers/Equal.swift
+2 −2 Nimble/Matchers/Match.swift
+4 −35 Nimble/Matchers/MatcherProtocols.swift
+129 −62 Nimble/Matchers/RaisesException.swift
+79 −0 Nimble/ObjCExpectation.swift
+4 −4 Nimble/Utils/Stringers.swift
+48 −55 Nimble/Wrappers/AsyncMatcherWrapper.swift
+0 −28 Nimble/Wrappers/BasicMatcherWrapper.swift
+0 −18 Nimble/Wrappers/FullMatcherWrapper.swift
+56 −16 Nimble/Wrappers/MatcherFunc.swift
+0 −56 Nimble/Wrappers/NonNilMatcherWrapper.swift
+17 −93 Nimble/Wrappers/ObjCMatcher.swift
+8 −4 Nimble/objc/DSL.h
+16 −4 Nimble/objc/DSL.m
+6 −7 NimbleTests/AsynchronousTest.swift
+44 −21 NimbleTests/Helpers/utils.swift
+74 −0 NimbleTests/Matchers/AllPassTest.swift
+18 −0 NimbleTests/Matchers/BeAKindOfTest.swift
+20 −0 NimbleTests/Matchers/BeAnInstanceOfTest.swift
+1 −1 NimbleTests/Matchers/BeEmptyTest.swift
+9 −9 NimbleTests/Matchers/BeIdenticalToObjectTest.swift
+2 −2 NimbleTests/Matchers/BeIdenticalToTest.swift
+22 −0 NimbleTests/Matchers/BeLogicalTest.swift
+1 −1 NimbleTests/Matchers/BeNilTest.swift
+2 −2 NimbleTests/Matchers/BeginWithTest.swift
+2 −2 NimbleTests/Matchers/EndWithTest.swift
+31 −0 NimbleTests/Matchers/EqualTest.swift
+122 −39 NimbleTests/Matchers/RaisesExceptionTest.swift
+4 −0 NimbleTests/objc/NimbleSpecHelper.h
+38 −0 NimbleTests/objc/ObjCAllPassTest.m
+133 −16 NimbleTests/objc/ObjCRaiseExceptionTest.m
+75 −32 README.md
+37 −0 circle.yml
+5 −5 test

0 comments on commit 63269dc

Please sign in to comment.