Skip to content

Commit

Permalink
Milvus : Added properties to dbConfig parameter in function fromExist…
Browse files Browse the repository at this point in the history
…ingCollection (langchain-ai#832)

* Milvus : Added properties to dbConfig parameter in function fromExistingCollection

* [Mod] Updated type to MilvusLibArgs

* Formatting issue. Removed comma
  • Loading branch information
arijit-chowdhury-genea authored Apr 16, 2023
1 parent f45394e commit 26306e3
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions langchain/src/vectorstores/milvus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,7 @@ export class Milvus extends VectorStore {

static async fromExistingCollection(
embeddings: Embeddings,
dbConfig: {
collectionName: string;
url?: string;
}
dbConfig: MilvusLibArgs
): Promise<Milvus> {
const instance = new this(embeddings, dbConfig);
await instance.ensureCollection();
Expand Down

0 comments on commit 26306e3

Please sign in to comment.