Officially deprecate bin.lua.

safebaseline · Sep 24, 2018 · 173a99e · 173a99e
1 parent be2910a
commit 173a99e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,10 @@
 #Nmap Changelog ($Id$); -*-text-*-
 
+o [NSE] bin.lua is officially deprecated. Lua 5.3, added 2 years ago in Nmap
+  7.25BETA2, has native support for binary data packing via string.pack and
+  string.unpack. All existing scripts and libraries have been updated.
+  [Daniel Miller]
+
 o [NSE] tls.lua when creating a client_hello message will now only use a SSLv3
   record layer if the protocol version is SSLv3. Some TLS implementations will
   not handshake with a client offering less than TLSv1.0. Scripts will have to

diff --git a/nselib/bin.lua b/nselib/bin.lua
@@ -44,6 +44,8 @@
 
 local debug4 = require "stdnse".debug4
 local debug5 = require "stdnse".debug5
+local verbose = require "stdnse".verbose
+verbose(0, "DEPRECATION WARNING: bin.lua is deprecated. Please use Lua 5.3 string.pack")
 
 local assert = assert
 local error = error

diff --git a/nselib/unittest.lua b/nselib/unittest.lua
@@ -33,7 +33,6 @@ local libs = {
 "asn1",
 "base32",
 "base64",
-"bin",
 "bitcoin",
 "bits",
 "bittorrent",